Skip to content

fix ros_gz_bridge message type for Gazebo Harmonic #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2025

Conversation

luffydod
Copy link
Contributor

@luffydod luffydod commented Jul 2, 2025

Description

This PR updates the message types used in ROS-Gazebo bridge nodes to properly support Gazebo Harmonic. The current implementation uses ignition.msgs.* which is for older Gazebo/Ignition versions, while Gazebo Harmonic requires gz.msgs.* as specified in the repository README.

Changes

  • Updated clock bridge node in sim.launch.py to use gz.msgs.Clock instead of ignition.msgs.Clock
  • Updated all message types in create3_ros_gz_bridge.launch.py, replacing all occurrences of ignition.msgs.* with gz.msgs.*
  • Commented out the old message types for reference where appropriate

Testing

Tested with Gazebo Harmonic, confirming that all bridges work correctly with these changes. This ensures proper communication between ROS 2 and Gazebo Harmonic simulation.

Motivation

These changes align the code with the correct message namespace convention for Gazebo Harmonic and fix compatibility issues when using the latest Gazebo version as recommended in the documentation.

@justinIRBT
Copy link
Collaborator

Do you know why the build_and_test is failing on this branch?

@luffydod
Copy link
Contributor Author

luffydod commented Jul 8, 2025

Do you know why the build_and_test is failing on this branch?您知道为什么 build_and_test 在此分支上失败吗?

I noticed the build_and_test CI failure, but it seems unrelated to the changes in this PR. Based on the error log, it might be caused by an expired GPG key in the ROS repository.

@skyegalaxy
Copy link
Collaborator

Do you know why the build_and_test is failing on this branch?您知道为什么 build_and_test 在此分支上失败吗?

I noticed the build_and_test CI failure, but it seems unrelated to the changes in this PR. Based on the error log, it might be caused by an expired GPG key in the ROS repository.

we're validating a fix in this PR: #242

@skyegalaxy
Copy link
Collaborator

Do you know why the build_and_test is failing on this branch?您知道为什么 build_and_test 在此分支上失败吗?

I noticed the build_and_test CI failure, but it seems unrelated to the changes in this PR. Based on the error log, it might be caused by an expired GPG key in the ROS repository.

ok @luffydod , we got CI passing again on our end. Can you please rebase and see if that fixes it for you?

@luffydod
Copy link
Contributor Author

luffydod commented Jul 9, 2025

Do you know why the build_and_test is failing on this branch?您知道为什么 build_and_test 在此分支上失败吗?

I noticed the build_and_test CI failure, but it seems unrelated to the changes in this PR. Based on the error log, it might be caused by an expired GPG key in the ROS repository.

ok @luffydod , we got CI passing again on our end. Can you please rebase and see if that fixes it for you?

Thanks! I've just rebased onto the latest jazzy and force-pushed.

@justinIRBT justinIRBT merged commit 1fccb76 into iRobotEducation:jazzy Jul 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants