-
Notifications
You must be signed in to change notification settings - Fork 0
Changes Provider and Direct Comparison functionality #245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…l version of processing to use. Update view creation to use default view with all models.
…kend and input based on ChangedECInstance
…ation for UI purposes. Maintain visibility of driven elements when looking at models that contain changes for those driven elements.
… caused driven changes. Make relationships definable by frontend application instead of hard-coding it in the backend.
packages/changed-elements-react/src/widgets/EnhancedElementsInspector.tsx
Outdated
Show resolved
Hide resolved
packages/changed-elements-react/src/widgets/EnhancedElementsInspector.tsx
Show resolved
Hide resolved
packages/changed-elements-react/src/widgets/EnhancedElementsInspector.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds a “direct comparison” workflow to both the test app and the changed-elements-react
library by wiring in a new changes‐provider RPC path, custom styling overrides, and a selection callback.
- Introduce
useDirectComparison
flag and registerChangesRpcInterface
/ChangesRpcImpl
on frontend and backend - Extend
VersionCompare
options to acceptchangesProvider
,colorOverrideProvider
, andonInstancesSelected
- Update widgets and visualization handlers to highlight driven elements and invoke custom callbacks
Reviewed Changes
Copilot reviewed 33 out of 34 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
packages/test-app-frontend/src/environment.ts | Add useDirectComparison flag from environment variables |
packages/test-app-frontend/src/App/ITwinJsApp/ITwinJsApp.tsx | Register ChangesRpcInterface , pass custom providers into VersionCompare.initialize |
packages/test-app-backend/src/RPC/ChangesRpcInterface.ts | Define new RPC interface for fetching changed instances |
packages/test-app-backend/src/RPC/ChangesRpcImpl.ts | Implement the RPC using ChangedInstancesProcessor |
packages/changed-elements-react/src/api/VersionCompare.ts | Expand VersionCompareOptions to include changesProvider , colorOverrideProvider , and onInstancesSelected |
packages/changed-elements-react/src/widgets/EnhancedElementsInspector.tsx | Invoke onInstancesSelected and inject driven-element highlighting |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
packages/changed-elements-react/src/widgets/EnhancedElementsInspector.tsx
Outdated
Show resolved
Hide resolved
packages/changed-elements-react/src/widgets/EnhancedElementsInspector.tsx
Outdated
Show resolved
Hide resolved
Looks like the lock file is not correct |
Yes, I resolved that as well, had to update the pnpm version in the pipeline and fix some of the linting. See: |
This PR aims to enhance changed elements react for:
Frontend Enhancements:
Backend Enhancements:
Test App Changes:
The Rpc is being implemented temporarily as part of the test-app-backend, but we will aim to move it to a separate package (potentially imodel-sync) to be consumable by other applications.