-
Notifications
You must be signed in to change notification settings - Fork 0
🐛Bug Fixes And List Virtualization #253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion key for clarity
🦋 Changeset detectedLatest commit: 97a2956 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
CalebGerman
commented
Aug 8, 2025
packages/changed-elements-react/src/NamedVersionSelector/NamedVersionSelector.tsx
Outdated
Show resolved
Hide resolved
CalebGerman
commented
Aug 8, 2025
packages/changed-elements-react/src/NamedVersionSelector/NamedVersionSelector.tsx
Show resolved
Hide resolved
CalebGerman
commented
Aug 8, 2025
packages/changed-elements-react/src/NamedVersionSelector/NamedVersionSelector.tsx
Outdated
Show resolved
Hide resolved
CalebGerman
commented
Aug 8, 2025
packages/changed-elements-react/src/NamedVersionSelector/useComparisonJobs.ts
Show resolved
Hide resolved
diegopinate
reviewed
Aug 11, 2025
packages/changed-elements-react/src/clients/iTwinIModelsClient.ts
Outdated
Show resolved
Hide resolved
packages/changed-elements-react/src/NamedVersionSelector/useNamedVersionsList.tsx
Show resolved
Hide resolved
packages/changed-elements-react/src/NamedVersionSelector/NamedVersionSelector.tsx
Outdated
Show resolved
Hide resolved
packages/changed-elements-react/src/NamedVersionSelector/useNamedVersionsList.tsx
Outdated
Show resolved
Hide resolved
packages/changed-elements-react/src/NamedVersionSelector/useNamedVersionsList.tsx
Outdated
Show resolved
Hide resolved
packages/changed-elements-react/src/NamedVersionSelector/useNamedVersionsList.tsx
Outdated
Show resolved
Hide resolved
packages/changed-elements-react/src/NamedVersionSelector/useNamedVersionsList.tsx
Outdated
Show resolved
Hide resolved
…list. If selected entry is processing, show loading spinner. If available and not processing disable button
CalebGerman
commented
Aug 11, 2025
packages/changed-elements-react/src/NamedVersionSelector/NamedVersionSelector.tsx
Show resolved
Hide resolved
CalebGerman
commented
Aug 11, 2025
packages/changed-elements-react/src/NamedVersionSelector/NamedVersionSelector.tsx
Outdated
Show resolved
Hide resolved
CalebGerman
commented
Aug 11, 2025
packages/changed-elements-react/src/NamedVersionSelector/NamedVersionSelector.tsx
Outdated
Show resolved
Hide resolved
CalebGerman
commented
Aug 11, 2025
packages/changed-elements-react/src/NamedVersionSelector/NamedVersionSelector.tsx
Outdated
Show resolved
Hide resolved
diegopinate
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The named version selector now has a virtualized list of entries. This prevents massive upfront loading.
Pr also fixes the following issues :