Add FormatSetFormatsProvider to ecschema-metadata #8438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hl662
requested review from
ColinKerr,
christophermlawson and
StefanApfel-Bentley
as code owners
rschili
approved these changes
Aug 19, 2025
christophermlawson
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iTwin/viewer-components-react#1404 adds support for customizing formats in the repo's test viewer. It uses concepts of FormatSet and FormatsProvider to achieve so, and it is increasingly likely this will be useful for other viewers. Thus, adding a
FormatSetFormatsProviderinterface to ecschema-metadata to support backends and frontends usage of this.P.S: In the PR above, a FormatManager is used to coordinate system interaction between the FormatSetFormatProvider and potentially multiple formatSets. TBD if it should be moved into itwinjs-core, we'll see if there's demand for it to be consumed by both backends and frontends.