Tree widget: Add support for AppUI 5.0 #1147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saskliutas
requested changes
Jan 22, 2025
Co-authored-by: Saulius Skliutas <24278440+saskliutas@users.noreply.github.com>
JonasDov
reviewed
Jan 22, 2025
Co-authored-by: JonasDov <100586436+JonasDov@users.noreply.github.com>
aruniverse
approved these changes
Jan 22, 2025
saskliutas
reviewed
Jan 22, 2025
...napshots/Models-tree-Density-default-instances-focus---too-many-results-1-chromium-linux.png
Outdated
Show resolved
Hide resolved
We'll need to wait for all repo packages to upgrade for AppUI v5 support before we can bump test-viewer's dependency. |
saskliutas
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1143.
AppUI 5.x dropped cjs support, so we had to get our tests to run in ESM mode too. Also added
type: "module"andexportsattributes topackage.json.