-
Notifications
You must be signed in to change notification settings - Fork 34
Update getFilteredPaths
documentation
#1335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tree-Widget benchmark
Benchmark suite | Current: 6b892a9 | Previous: de399ef | Deviation | Status |
---|---|---|---|---|
categories tree creates initial filtered view for 50k items |
2395.53 ms |
2376.45 ms |
0.80% |
〰️ |
categories tree creates initial filtered view for 50k items (P95 of main thread blocks) |
1680 ms |
1685 ms |
-0.30% |
〰️ |
categories tree changing category visibility changes visibility for 50k subCategories |
10821.6 ms |
14834.22 ms |
-27.05% |
✅ |
categories tree changing category visibility changes visibility for 50k subCategories (P95 of main thread blocks) |
4381 ms |
746 ms |
487.27% |
🚨 |
categories tree changing definition container visibility changes visibility for 50k categories |
7210.79 ms |
7788.89 ms |
-7.42% |
〰️ |
categories tree changing definition container visibility changes visibility for 50k categories (P95 of main thread blocks) |
3854 ms |
5068 ms |
-23.95% |
✅ |
models tree creates initial filtered view for 50k target items |
2307.25 ms |
2270.06 ms |
1.64% |
〰️ |
models tree creates initial filtered view for 50k target items (P95 of main thread blocks) |
302 ms |
90 ms |
235.56% |
🚨 |
models tree changing model visibility changes visibility for 50k elements |
47855.91 ms |
53519.33 ms |
-10.58% |
✅ |
models tree changing model visibility changes visibility for 50k elements (P95 of main thread blocks) |
286 ms |
109 ms |
162.39% |
🚨 |
models tree changing category visibility changes visibility for 50k elements |
46816.9 ms |
57418.05 ms |
-18.46% |
✅ |
models tree changing category visibility changes visibility for 50k elements (P95 of main thread blocks) |
273 ms |
119 ms |
129.41% |
🚨 |
models tree changing per-model-category override changes visibility for 50k elements |
47580.95 ms |
57269.61 ms |
-16.92% |
✅ |
models tree changing per-model-category override changes visibility for 50k elements (P95 of main thread blocks) |
255 ms |
298 ms |
-14.43% |
〰️ |
models tree changing element visibility changes only parent nodes visibility with 50k elements |
48339.21 ms |
58776.95 ms |
-17.76% |
✅ |
models tree changing element visibility changes only parent nodes visibility with 50k elements (P95 of main thread blocks) |
497 ms |
401 ms |
23.94% |
🚨 |
This comment was automatically generated by workflow using github-action-benchmark.
grigasp
reviewed
May 29, 2025
packages/itwin/tree-widget/src/tree-widget-react/components/trees/models-tree/UseModelsTree.tsx
Outdated
Show resolved
Hide resolved
packages/itwin/tree-widget/src/tree-widget-react/components/trees/models-tree/UseModelsTree.tsx
Outdated
Show resolved
Hide resolved
packages/itwin/tree-widget/src/tree-widget-react/components/trees/models-tree/UseModelsTree.tsx
Outdated
Show resolved
Hide resolved
packages/itwin/tree-widget/src/tree-widget-react/components/trees/models-tree/UseModelsTree.tsx
Outdated
Show resolved
Hide resolved
packages/itwin/tree-widget/src/tree-widget-react/components/trees/models-tree/UseModelsTree.tsx
Outdated
Show resolved
Hide resolved
apps/learning-snippets/src/test/tree-widget/FilteredPaths.test.tsx
Outdated
Show resolved
Hide resolved
change/@itwin-tree-widget-react-4979d818-712d-4f2a-b27e-ac9adef6517b.json
Outdated
Show resolved
Hide resolved
…ees/models-tree/UseModelsTree.tsx Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com>
…ees/models-tree/UseModelsTree.tsx Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com>
…ees/models-tree/UseModelsTree.tsx Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com>
…ees/models-tree/UseModelsTree.tsx Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com>
…ees/models-tree/UseModelsTree.tsx Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com>
…ees/models-tree/UseModelsTree.tsx Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com>
Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com>
Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com>
…f6517b.json Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com>
grigasp
approved these changes
Jun 2, 2025
apps/learning-snippets/src/test/tree-widget/FilteredPaths.test.tsx
Outdated
Show resolved
Hide resolved
apps/learning-snippets/src/test/tree-widget/FilteredPaths.test.tsx
Outdated
Show resolved
Hide resolved
apps/learning-snippets/src/test/tree-widget/FilteredPaths.test.tsx
Outdated
Show resolved
Hide resolved
….tsx Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com>
….tsx Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com>
….tsx Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1319.
Added documentation explaining
getFilteredPaths
and its usage