Skip to content

Conversation

JonasDov
Copy link
Contributor

closes #1319.

Added documentation explaining getFilteredPaths and its usage

@JonasDov JonasDov requested review from a team as code owners May 28, 2025 12:04
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tree-Widget benchmark

Benchmark suite Current: 6b892a9 Previous: de399ef Deviation Status
categories tree creates initial filtered view for 50k items 2395.53 ms 2376.45 ms 0.80% 〰️
categories tree creates initial filtered view for 50k items (P95 of main thread blocks) 1680 ms 1685 ms -0.30% 〰️
categories tree changing category visibility changes visibility for 50k subCategories 10821.6 ms 14834.22 ms -27.05%
categories tree changing category visibility changes visibility for 50k subCategories (P95 of main thread blocks) 4381 ms 746 ms 487.27% 🚨
categories tree changing definition container visibility changes visibility for 50k categories 7210.79 ms 7788.89 ms -7.42% 〰️
categories tree changing definition container visibility changes visibility for 50k categories (P95 of main thread blocks) 3854 ms 5068 ms -23.95%
models tree creates initial filtered view for 50k target items 2307.25 ms 2270.06 ms 1.64% 〰️
models tree creates initial filtered view for 50k target items (P95 of main thread blocks) 302 ms 90 ms 235.56% 🚨
models tree changing model visibility changes visibility for 50k elements 47855.91 ms 53519.33 ms -10.58%
models tree changing model visibility changes visibility for 50k elements (P95 of main thread blocks) 286 ms 109 ms 162.39% 🚨
models tree changing category visibility changes visibility for 50k elements 46816.9 ms 57418.05 ms -18.46%
models tree changing category visibility changes visibility for 50k elements (P95 of main thread blocks) 273 ms 119 ms 129.41% 🚨
models tree changing per-model-category override changes visibility for 50k elements 47580.95 ms 57269.61 ms -16.92%
models tree changing per-model-category override changes visibility for 50k elements (P95 of main thread blocks) 255 ms 298 ms -14.43% 〰️
models tree changing element visibility changes only parent nodes visibility with 50k elements 48339.21 ms 58776.95 ms -17.76%
models tree changing element visibility changes only parent nodes visibility with 50k elements (P95 of main thread blocks) 497 ms 401 ms 23.94% 🚨

This comment was automatically generated by workflow using github-action-benchmark.

JonasDov and others added 11 commits June 2, 2025 09:35
…ees/models-tree/UseModelsTree.tsx

Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com>
…ees/models-tree/UseModelsTree.tsx

Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com>
…ees/models-tree/UseModelsTree.tsx

Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com>
…ees/models-tree/UseModelsTree.tsx

Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com>
…ees/models-tree/UseModelsTree.tsx

Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com>
…ees/models-tree/UseModelsTree.tsx

Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com>
Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com>
Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com>
…f6517b.json

Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com>
JonasDov and others added 4 commits June 2, 2025 13:52
….tsx

Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com>
….tsx

Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com>
….tsx

Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com>
@grigasp grigasp linked an issue Jun 2, 2025 that may be closed by this pull request
@JonasDov JonasDov merged commit ca930b1 into master Jun 2, 2025
14 checks passed
@JonasDov JonasDov deleted the JonasD/getFilteredPaths-docs branch June 2, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tree widget: filtering is broken when getFilteredPaths is used
2 participants