Skip to content

Conversation

hl662
Copy link
Contributor

@hl662 hl662 commented May 30, 2025

  • Bump peer deps for @itwin/measure-tools-react to itwin v5
  • Add bearing field to MeasureDistanceTool's widget properties.
  • Enable more text markers to dynamically update when formats changed events are emitted via IModelApp.quantityFormatter (Angle was fixed)
  • Integrate Distance, Angle, Area, Location, Radius Measurement subclasses to use IModelApp.formatsProvider to retrieve formatting props.
  • Add a measurementFormattingProps property to MeasureToolsUiProviderOptions. By default, Bearing will not be included unless an app explicitly passes in the MeasurementFormattingProps for bearing, like so:
	....other props for MeasureToolsUiItemsProvider
        measurementFormattingProps: {
          distance: {
            bearing: {
              koqName: "RoadRailUnits.Bearing",
              persistenceUnitName: "Units.RAD"
            }
          }
        }

@hl662 hl662 changed the title [measure-tools] Use IModelApp.formatsProvider for formatting [measure-tools] Update quantity formatting logic, add bearing support Jun 3, 2025
@hl662 hl662 changed the title [measure-tools] Update quantity formatting logic, add bearing support [measure-tools] Update quantity formatting logic, add bearing to distance measure Jun 3, 2025
@hl662 hl662 linked an issue Jun 3, 2025 that may be closed by this pull request
@hl662 hl662 marked this pull request as ready for review June 9, 2025 21:43
@hl662 hl662 requested review from simnorm, a-gagnon, bsy-nicholasw and a team as code owners June 9, 2025 21:43
@hl662 hl662 requested a review from mathieu-fournier June 9, 2025 21:43
Copy link
Member

@aruniverse aruniverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first pass looks ok. please have civil team review, they will be impacted

Copy link
Member

@aruniverse aruniverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first pass looks ok. please have civil team review, they will be impacted

@hl662 hl662 merged commit ffe4533 into master Jun 23, 2025
12 checks passed
@hl662 hl662 deleted the nam/measure-tools-itwin5 branch June 23, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Bearing in Measure Distance Tool.
7 participants