-
Notifications
You must be signed in to change notification settings - Fork 34
[measure-tools] Update quantity formatting logic, add bearing to distance measure #1336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hl662
commented
Jun 3, 2025
hl662
commented
Jun 3, 2025
packages/itwin/measure-tools/src/measurements/DistanceMeasurement.ts
Outdated
Show resolved
Hide resolved
grigasp
reviewed
Jun 4, 2025
hl662
commented
Jun 4, 2025
packages/itwin/measure-tools/src/measurements/AreaMeasurement.ts
Outdated
Show resolved
Hide resolved
aruniverse
reviewed
Jun 9, 2025
aruniverse
reviewed
Jun 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
first pass looks ok. please have civil team review, they will be impacted
raplemie
reviewed
Jun 10, 2025
a-gagnon
reviewed
Jun 11, 2025
aruniverse
reviewed
Jun 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
first pass looks ok. please have civil team review, they will be impacted
packages/itwin/measure-tools/src/test/measure-tools/_Setup.test.ts
Outdated
Show resolved
Hide resolved
… a namespace which is more fitting. (#1346)
a-gagnon
approved these changes
Jun 23, 2025
aruniverse
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
measurementFormattingProps
property toMeasureToolsUiProviderOptions
. By default, Bearing will not be included unless an app explicitly passes in theMeasurementFormattingProps
for bearing, like so: