-
Notifications
You must be signed in to change notification settings - Fork 34
[Tree-widget]: Add learning snippet for getSubTreePaths
#1388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tree-Widget benchmark
Benchmark suite | Current: 86fd4de | Previous: 583279d | Deviation | Status |
---|---|---|---|---|
categories tree creates initial filtered view for 50k items |
2403.72 ms |
2444.81 ms |
-1.68% |
〰️ |
categories tree creates initial filtered view for 50k items (P95 of main thread blocks) |
1658 ms |
1686 ms |
-1.66% |
〰️ |
categories tree changing category visibility changes visibility for 50k subCategories |
9964.72 ms |
10356.38 ms |
-3.78% |
〰️ |
categories tree changing category visibility changes visibility for 50k subCategories (P95 of main thread blocks) |
3639 ms |
3998 ms |
-8.98% |
〰️ |
categories tree changing definition container visibility changes visibility for 50k categories |
7303.34 ms |
6596.02 ms |
10.72% |
🚨 |
categories tree changing definition container visibility changes visibility for 50k categories (P95 of main thread blocks) |
4663 ms |
3390 ms |
37.55% |
🚨 |
models tree creates initial filtered view for 50k target items |
2283.59 ms |
2308.47 ms |
-1.08% |
〰️ |
models tree creates initial filtered view for 50k target items (P95 of main thread blocks) |
350 ms |
332 ms |
5.42% |
〰️ |
models tree validates categories visibility for imodel with 50k categories |
14587.82 ms |
14602.88 ms |
-0.10% |
〰️ |
models tree validates categories visibility for imodel with 50k categories (P95 of main thread blocks) |
4151 ms |
4088 ms |
1.54% |
〰️ |
models tree changing model visibility changes visibility for 50k elements |
45639.18 ms |
49329.04 ms |
-7.48% |
〰️ |
models tree changing model visibility changes visibility for 50k elements (P95 of main thread blocks) |
344 ms |
369 ms |
-6.78% |
〰️ |
models tree changing category visibility changes visibility for 50k elements |
48984.88 ms |
48541.95 ms |
0.91% |
〰️ |
models tree changing category visibility changes visibility for 50k elements (P95 of main thread blocks) |
273 ms |
246 ms |
10.98% |
〰️ |
models tree changing per-model-category override changes visibility for 50k elements |
46993.62 ms |
48429.92 ms |
-2.97% |
〰️ |
models tree changing per-model-category override changes visibility for 50k elements (P95 of main thread blocks) |
273 ms |
237 ms |
15.19% |
〰️ |
models tree changing element visibility changes only parent nodes visibility with 50k elements |
48576.22 ms |
49451.71 ms |
-1.77% |
〰️ |
models tree changing element visibility changes only parent nodes visibility with 50k elements (P95 of main thread blocks) |
475 ms |
500 ms |
-5% |
〰️ |
This comment was automatically generated by workflow using github-action-benchmark.
grigasp
approved these changes
Jul 31, 2025
apps/learning-snippets/src/test/tree-widget/SubTreePaths.test.tsx
Outdated
Show resolved
Hide resolved
apps/learning-snippets/src/test/tree-widget/SubTreePaths.test.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com>
Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added learning snippet for
getSubTreePaths
usage.