Skip to content

Conversation

grigasp
Copy link
Member

@grigasp grigasp commented Aug 7, 2025

For the test case at hand, there were ~1900 where clauses, so they were all placed into a single huge query. On a local briefcase the query took ~3 minutes to run, on GPB - more than 5 minutes.

Splitting it into chunks of 100 where clauses allows us to execute them in parallel and in GPB case they take ~11 seconds.

@grigasp grigasp requested a review from JonasDov August 7, 2025 08:54
@grigasp grigasp requested review from a team as code owners August 7, 2025 08:54
@grigasp grigasp enabled auto-merge (squash) August 7, 2025 08:54
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tree-Widget benchmark

Benchmark suite Current: ca38eed Previous: 44c526a Deviation Status
categories tree creates initial filtered view for 50k items 2506.22 ms 2531.49 ms -1.00% 〰️
categories tree creates initial filtered view for 50k items (P95 of main thread blocks) 1665 ms 1669 ms -0.24% 〰️
categories tree changing category visibility changes visibility for 50k subCategories 9664.38 ms 9514.55 ms 1.57% 〰️
categories tree changing category visibility changes visibility for 50k subCategories (P95 of main thread blocks) 3182 ms 3190 ms -0.25% 〰️
categories tree changing definition container visibility changes visibility for 50k categories 6801 ms 6326.05 ms 7.51% 〰️
categories tree changing definition container visibility changes visibility for 50k categories (P95 of main thread blocks) 3572 ms 3111 ms 14.82% 🚨
models tree creates initial filtered view for 50k target items 2198.4 ms 2216.81 ms -0.83% 〰️
models tree creates initial filtered view for 50k target items (P95 of main thread blocks) 82 ms 296 ms -72.30%
models tree validates categories visibility for imodel with 50k categories 15287.48 ms 15535.35 ms -1.60% 〰️
models tree validates categories visibility for imodel with 50k categories (P95 of main thread blocks) 4156 ms 4401 ms -5.57% 〰️
models tree changing model visibility changes visibility for 50k elements 47985.81 ms 45866.25 ms 4.62% 〰️
models tree changing model visibility changes visibility for 50k elements (P95 of main thread blocks) 263 ms 252 ms 4.37% 〰️
models tree changing category visibility changes visibility for 50k elements 47579.59 ms 46551.95 ms 2.21% 〰️
models tree changing category visibility changes visibility for 50k elements (P95 of main thread blocks) 358 ms 246 ms 45.53% 🚨
models tree changing per-model-category override changes visibility for 50k elements 48695.26 ms 46068.5 ms 5.70% 〰️
models tree changing per-model-category override changes visibility for 50k elements (P95 of main thread blocks) 263 ms 244 ms 7.79% 〰️
models tree changing element visibility changes only parent nodes visibility with 50k elements 48470.55 ms 46772.99 ms 3.63% 〰️
models tree changing element visibility changes only parent nodes visibility with 50k elements (P95 of main thread blocks) 459 ms 469 ms -2.13% 〰️

This comment was automatically generated by workflow using github-action-benchmark.

@grigasp grigasp merged commit d9158a7 into master Aug 7, 2025
14 checks passed
@grigasp grigasp deleted the tree-widget/make-model-category-elements-query-chunks-smaller branch August 7, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants