Skip to content

Conversation

hl662
Copy link
Contributor

@hl662 hl662 commented Aug 7, 2025

Following iTwin/itwinjs-core#8399, which is available in core 5.1.0:

  • Fix documentation to clarify RRU.BEARING, not RRU.Bearing for bearing measurement.
  • Use separate KoQ for coordinate values, AecUnits.LENGTH_COORDINATE to format values specific to coordinates, separate from standard length values.
  • Update peerDeps for @itwin/measure-tool-react's itwin-core packages to 5.1.0 to support length coordinate koq.
  • Update test viewer to use 5.1.0 itwin-core pkgs.
  • Fallback to using QuantityTypes for measurements, in case older iModels doesn't include AecUnits. (Which can be a very common case after discovery in DesignReview with our older test iModels)

Tested: Observe the formatting of Distance in widget, the precision (4 places) is different from the precision (2 places) of the value in the start and end coordinates.
image

@hl662 hl662 self-assigned this Aug 7, 2025
@hl662 hl662 marked this pull request as ready for review August 8, 2025 15:29
@hl662 hl662 requested review from simnorm, a-gagnon, bsy-nicholasw and a team as code owners August 8, 2025 15:29
@hl662 hl662 merged commit bcdd6aa into master Aug 8, 2025
12 checks passed
@hl662 hl662 deleted the nam/coordinate-koq branch August 8, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants