Skip to content

Conversation

JonasDov
Copy link
Contributor

@JonasDov JonasDov commented Aug 12, 2025

Prerequisite for #1362

Did the same thing that was done in #1401.
Models and classifications trees got updated to use methods from categories visibility handler.

Additionally:

  • Models tree visibility handler determines models visibility a little differently from categories or classifications trees. It also checks if Viewport has spatial view. Added this check to getModelsTreeVisibilityStatus in models tree visibility handler.
  • Added getCategoriesElementModels to ModelsTreeIdsCache.
  • Classifications tree, when determining visibility for categories and elements also checks if Viewport has 2d or 3d view. Added this check to getCategoriesVisibilityStatus and getElementsVisibilityStatus in classifications tree visibility handler.
  • Changed names and parameters of ModelsTreeVisibilityHandlerOverrides. It is a breaking change, but the migration should not be too complicated.

@JonasDov JonasDov requested review from a team as code owners August 12, 2025 14:51
@JonasDov JonasDov changed the base branch from master to tree-widget/next August 12, 2025 14:52
@JonasDov JonasDov linked an issue Aug 12, 2025 that may be closed by this pull request
@JonasDov JonasDov enabled auto-merge (squash) August 13, 2025 08:47
@JonasDov JonasDov merged commit dc6fe8d into tree-widget/next Aug 13, 2025
10 checks passed
@JonasDov JonasDov deleted the JonasD/use-visibility-methods-from-categories-visibility-handler branch August 13, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tree widget: Unify visibility handlers
2 participants