Skip to content

[Tree widget]: Adjust visibility handling for filtered trees #1406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Aug 19, 2025
Merged

[Tree widget]: Adjust visibility handling for filtered trees #1406

merged 13 commits into from
Aug 19, 2025

Conversation

JonasDov
Copy link
Contributor

Prerequisite for #1362
Unified how filtered trees are created.

@JonasDov JonasDov requested review from a team as code owners August 13, 2025 09:43
grigasp
grigasp reviewed Aug 13, 2025
View reviewed changes
Copy link
Member

@grigasp grigasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One pattern that I see is that non-exported module-internal types and functions are being defined at the top of the source files, before the exported APIs. I'd like such APIs to be moved to the bottom, so the exported (important) ones are at the top.

grigasp
grigasp reviewed Aug 18, 2025
View reviewed changes
@JonasDov JonasDov merged commit e69be02 into tree-widget/next Aug 19, 2025
10 checks passed
@JonasDov JonasDov deleted the JonasD/visibility-handling-for-filtered-trees branch August 19, 2025 10:23
@JonasDov JonasDov linked an issue Aug 20, 2025 that may be closed by this pull request
Tree widget: Unify visibility handlers #1362
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grigasp grigasp grigasp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tree widget: Unify visibility handlers
2 participants
@JonasDov @grigasp