-
Notifications
You must be signed in to change notification settings - Fork 209
Feat: quote assistant message for asking follow up questions #256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@buneeIsSlo is attempting to deploy a commit to the zola Team on Vercel. A member of the Team first needs to authorize it. |
@ibelick, please review this and let me know if you'd like me to add or change anything. I will try and add some more recordings. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hey @buneeIsSlo, thanks for the PR. ./app/components/multi-chat/multi-conversation.tsx:61:12
Type error: Property 'onQuote' is missing in type '{ children: string; id: string; variant: "assistant"; parts: (TextUIPart | ReasoningUIPart | ToolInvocationUIPart | SourceUIPart | FileUIPart | StepStartUIPart)[]; ... 7 more ...; className: string; }' but required in type 'MessageProps'.
59 |
60 | {response.message ? (
> 61 | <Message
| ^
62 | id={response.message.id}
63 | variant="assistant"
64 | parts={
Next.js build worker exited with code: 1 and signal: null
Error: Command "npm run build" exited with 1
Exiting build container |
@ibelick, it should be fine now. Please let me know if you'd like me to make any further changes. |
* feat: update chatinput * feat: add border sidebar * feat: improve dark mode
@ibelick, I was able to remove the However, the |
LGTM |
Overview
This PR implements a text selection and quote feature that allows users to select text from assistant messages and insert it as a quote into the chat input. The feature includes a floating quote button that appears when text is selected, with proper positioning and dismissal handling.
Preview after changes:
quote-response.mp4
Changes made
≥3
characters within assistant messagesuseClickOutside()
hook for proper dismissal(> text)
Edge cases handeled
<3
characters or whitespace-onlyManual testing
Resources