-
Notifications
You must be signed in to change notification settings - Fork 5
Changed SubgridContainer
to represent galvanically seperated grids
#1366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed SubgridContainer
to represent galvanically seperated grids
#1366
Conversation
src/test/groovy/edu/ie3/datamodel/utils/ContainerUtilsTest.groovy
Outdated
Show resolved
Hide resolved
…e-with-the-galvanical-seperation # Conflicts: # CHANGELOG.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there :)
src/test/groovy/edu/ie3/datamodel/utils/ContainerUtilsTest.groovy
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
One thing we missed here is clarifying whether we consider the transformer to be part of the 'SubGridContainer', and if so, whether it is part of the lower or upper grid. Excluding the transformer would make voltages within the container very simple and clear. However, this would mean that not all grid elements would be within the 'SubGridContainer'. I therefore tend to think that the connecting transformer should belong to the grid with the lower voltage level (but not the connecting node). What do you think @sebastian-peter and @staudtMarius? Once we agreed on a way we should update PSDM Docs and adapt OsmoGrid, which revealed this. |
@danielfeismann I think traditionally, we have (almost) handled it in the exact way you described. The transformer is supposed to be part of the lower sub grid. The upper connecting node of the transformer (which I think you meant there) is part of the sub grid as well, though, because otherwise we would have a connecting element (the transformer) for which one node (the upper) does not exist within the container. Check out PowerSystemDataModel/src/main/java/edu/ie3/datamodel/utils/ContainerUtils.java Lines 313 to 319 in c93fcf4
In my opinion, this approach is sufficiently well reasoned and should stay this way, however, there should definitely be documentation on this. |
Resolves #1226
Resolves #1310