Skip to content

Using NBVAL as validation for jupyter notebooks #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
Aug 20, 2025
Merged

Conversation

danielfeismann
Copy link
Member

resolves #351

@danielfeismann danielfeismann self-assigned this Aug 5, 2025
@danielfeismann danielfeismann added test documentation Improvements or additions to documentation labels Aug 5, 2025
@danielfeismann danielfeismann marked this pull request as ready for review August 6, 2025 06:54
# Conflicts:
#	poetry.lock
# Conflicts:
#	CHANGELOG.md
# Conflicts:
#	CHANGELOG.md
#	docs/nbs/input_models.ipynb
#	docs/nbs/result_models.ipynb
#	poetry.lock
@danielfeismann danielfeismann marked this pull request as draft August 12, 2025 15:21
@danielfeismann danielfeismann marked this pull request as ready for review August 19, 2025 21:02
Copy link
Member

@staudtMarius staudtMarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@staudtMarius staudtMarius merged commit 09f1ac0 into main Aug 20, 2025
6 checks passed
@staudtMarius staudtMarius deleted the df/#351-nbval branch August 20, 2025 08:48
@@ -22,6 +22,7 @@ numba = "^0.61.2"
scipy = "^1.16.1" # required by numba
geoalchemy2 = "^0.18.0"
psycopg2-binary = "^2.9.10"
nbval = "^0.11.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should've went to dev dependencies 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Notebooks Validation
3 participants