Skip to content

Refactoring data connections and container. #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Jun 24, 2025

Conversation

staudtMarius
Copy link
Member

Resolves #267
Resolves #268

@staudtMarius staudtMarius added the improvement Code readability, structure or efficiency is improved label Apr 7, 2025
@staudtMarius staudtMarius self-assigned this Apr 7, 2025
Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some thoughts from my side. Sorry, I was in suggestion mode ;) feel free to ignore whatever doesn't make sense to you.

@staudtMarius staudtMarius requested review from danielfeismann and removed request for danielfeismann June 10, 2025 09:26
Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some little things, beside the issue with the warning on empty set points.

Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@staudtMarius staudtMarius merged commit 9a2f537 into dev Jun 24, 2025
4 checks passed
@staudtMarius staudtMarius deleted the ms/#267-refactoring-data-connections branch June 24, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Code readability, structure or efficiency is improved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor data container Refactoring data connections
2 participants