Fix for code scanning alert: Workflow does not contain permissions #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
Addresses a security code scanning alert by restricting the GITHUB_TOKEN permissions for the conformance job to the minimum required scope (contents: read).
- Adds a
permissionsblock under theconformancejob - Grants only
contents: readto limit token privileges
igor-vovk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/igor-vovk/connect-rpc-scala/security/code-scanning/4
To fix the issue, we need to add a
permissionsblock to theconformancejob. Since the job only checks out the repository and runs Docker commands, it does not require any write permissions. The minimal permissions required arecontents: read. This change ensures that theGITHUB_TOKENhas the least privilege necessary to execute the job.Suggested fixes powered by Copilot Autofix. Review carefully before merging.