Skip to content

Specify executor for GRPC server/channel #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ import org.ivovk.connect_rpc_scala.http.*
import org.ivovk.connect_rpc_scala.http.QueryParams.*
import scalapb.json4s.{JsonFormat, Printer}

import java.util.concurrent.Executor
import scala.concurrent.ExecutionContext
import scala.concurrent.duration.*

object ConnectRouteBuilder {
Expand All @@ -28,8 +30,9 @@ object ConnectRouteBuilder {
case class ConnectRouteBuilder[F[_] : Async] private(
services: Seq[ServerServiceDefinition],
jsonPrinterConfigurator: Endo[Printer] = identity,
serverBuilderConfigurator: Endo[ServerBuilder[_]] = identity,
channelBuilderConfigurator: Endo[ManagedChannelBuilder[_]] = identity,
serverConfigurator: Endo[ServerBuilder[_]] = identity,
channelConfigurator: Endo[ManagedChannelBuilder[_]] = identity,
executor: Executor = ExecutionContext.global,
waitForShutdown: Duration = 5.seconds,
) {

Expand All @@ -38,11 +41,14 @@ case class ConnectRouteBuilder[F[_] : Async] private(
def withJsonPrinterConfigurator(method: Endo[Printer]): ConnectRouteBuilder[F] =
copy(jsonPrinterConfigurator = method)

def withServerBuilderConfigurator(method: Endo[ServerBuilder[_]]): ConnectRouteBuilder[F] =
copy(serverBuilderConfigurator = method)
def withServerConfigurator(method: Endo[ServerBuilder[_]]): ConnectRouteBuilder[F] =
copy(serverConfigurator = method)

def withChannelBuilderConfigurator(method: Endo[ManagedChannelBuilder[_]]): ConnectRouteBuilder[F] =
copy(channelBuilderConfigurator = method)
def withChannelConfigurator(method: Endo[ManagedChannelBuilder[_]]): ConnectRouteBuilder[F] =
copy(channelConfigurator = method)

def withExecutor(executor: Executor): ConnectRouteBuilder[F] =
copy(executor = executor)

def withWaitForShutdown(duration: Duration): ConnectRouteBuilder[F] =
copy(waitForShutdown = duration)
Expand All @@ -68,8 +74,9 @@ case class ConnectRouteBuilder[F[_] : Async] private(
for
channel <- InProcessChannelBridge.create(
services,
serverBuilderConfigurator,
channelBuilderConfigurator,
serverConfigurator,
channelConfigurator,
executor,
waitForShutdown,
)
yield
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import io.grpc.*
import io.grpc.inprocess.{InProcessChannelBuilder, InProcessServerBuilder}
import org.slf4j.{Logger, LoggerFactory}

import java.util.concurrent.TimeUnit
import java.util.concurrent.{Executor, TimeUnit}
import scala.concurrent.duration.Duration
import scala.jdk.CollectionConverters.*
import scala.util.chaining.*
Expand All @@ -17,36 +17,37 @@ object InProcessChannelBridge {

def create[F[_] : Sync](
services: Seq[ServerServiceDefinition],
serverBuilderConfigurator: Endo[ServerBuilder[?]] = identity,
channelBuilderConfigurator: Endo[ManagedChannelBuilder[?]] = identity,
serverConfigurator: Endo[ServerBuilder[?]],
channelConfigurator: Endo[ManagedChannelBuilder[?]],
executor: Executor,
waitForShutdown: Duration,
): Resource[F, Channel] = {
for
name <- Resource.eval(Sync[F].delay(InProcessServerBuilder.generateName()))
server <- createServer(name, services, waitForShutdown, serverBuilderConfigurator)
channel <- createStub(name, waitForShutdown, channelBuilderConfigurator)
server <- createServer(name, services, serverConfigurator, executor, waitForShutdown)
channel <- createStub(name, channelConfigurator, executor, waitForShutdown)
yield channel
}

private def createServer[F[_] : Sync](
name: String,
services: Seq[ServerServiceDefinition],
serverConfigurator: Endo[ServerBuilder[?]],
executor: Executor,
waitForShutdown: Duration,
serverBuilderConfigurator: Endo[ServerBuilder[?]] = identity,
): Resource[F, Server] = {
val acquire = Sync[F].delay {
InProcessServerBuilder.forName(name)
.directExecutor()
.addServices(services.asJava)
.pipe(serverBuilderConfigurator)
.build()
.start()
.executor(executor)
.pipe(serverConfigurator)
.build().start()
}
val release = (s: Server) => Sync[F].delay {
val res = s.shutdown().awaitTermination(waitForShutdown.toMillis, TimeUnit.MILLISECONDS)

if (!res) {
logger.warn(s"GRPC server did not shut down in $waitForShutdown")
logger.warn(s"GRPC server did not shut down in $waitForShutdown, consider increasing shutdown timeout")
}
}

Expand All @@ -55,20 +56,21 @@ object InProcessChannelBridge {

private def createStub[F[_] : Sync](
name: String,
channelConfigurator: Endo[ManagedChannelBuilder[?]],
executor: Executor,
waitForShutdown: Duration,
channelBuilderConfigurator: Endo[ManagedChannelBuilder[?]] = identity,
): Resource[F, ManagedChannel] = {
val acquire = Sync[F].delay {
InProcessChannelBuilder.forName(name)
.directExecutor()
.pipe(channelBuilderConfigurator)
.executor(executor)
.pipe(channelConfigurator)
.build()
}
val release = (c: ManagedChannel) => Sync[F].delay {
val res = c.shutdown().awaitTermination(waitForShutdown.toMillis, TimeUnit.MILLISECONDS)

if (!res) {
logger.warn(s"GRPC channel did not shut down in $waitForShutdown")
logger.warn(s"GRPC channel did not shut down in $waitForShutdown, consider increasing shutdown timeout")
}
}

Expand Down