Adds improved readout from install_deps.py #3104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR improves the user experience of the dependency installation process by implementing real-time output streaming and enhanced error handling in the install_deps.py script. The changes replace the previous approach of buffering all subprocess output until completion with a live streaming approach that provides immediate feedback to users.
- Replaces
subprocess.runwithsubprocess.Popenfor real-time output streaming - Adds better error handling with descriptive error messages
- Enhances user feedback during the installation process
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Hunter Hansen <50837800+hhansen-bdai@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Hunter Hansen <50837800+hhansen-bdai@users.noreply.github.com>
hhansen-bdai
force-pushed
the
hhansen/improve_install_deps_readout
branch
from
3b3e749 to
1d0c6cd
Compare
hhansen-bdai
requested review from
jtigue-bdai,
kellyguo11 and
Mayankm96
as code owners
Signed-off-by: Kelly Guo <kellyg@nvidia.com>
kellyguo11
approved these changes
Aug 8, 2025
kellyguo11
changed the title
Test Results Summary2 419 tests 2 011 ✅ 2h 18m 52s ⏱️ Results for commit 3e9d0b2. |
ooctipus
approved these changes
Aug 8, 2025
StephenWelch
pushed a commit
to StephenWelch/IsaacLab
that referenced
this pull request
Aug 17, 2025
# Description This adds improved readout from the subprocesses in `install_deps.py`. It will now print the output instead of printing everything at once when the process is finished. It also has improved error handling. This will help users to have a better understanding of their build process and more easily resolve issues. ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - New feature (non-breaking change which adds functionality) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task --> --------- Signed-off-by: Hunter Hansen <50837800+hhansen-bdai@users.noreply.github.com> Signed-off-by: Kelly Guo <kellyg@nvidia.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Kelly Guo <kellyg@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds improved readout from the subprocesses in
install_deps.py. It will now print the output instead of printing everything at once when the process is finished. It also has improved error handling. This will help users to have a better understanding of their build process and more easily resolve issues.Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there