Fixs isaaclab.sh to detect isaacsim_version accurately 4.5 or >= 5.0 #3139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ooctipus
requested review from
hhansen-bdai,
Mayankm96 and
kellyguo11
as code owners
ooctipus
changed the title
Test Results Summary2 419 tests 2 011 ✅ 2h 16m 43s ⏱️ Results for commit 8958d76. |
Mayankm96
reviewed
Aug 10, 2025
| @@ -43,33 +43,48 @@ install_system_deps() { | |||
| fi | |||
| } | |||
|
|
|||
| # Returns success (exit code 0 / "true") if the detected Isaac Sim version starts with 4.5, | |||
There was a problem hiding this comment.
Thanks for the fix. Does the isaaclab.bat file also need to be adapted?
There was a problem hiding this comment.
Maybe we should convert these shell/bat scripts to a python file to simplify the maintainance work between different OS platforms.
There was a problem hiding this comment.
Yeah, I think people generally also understand python more than bash.
Though I wonder if using python, could it be a lot more verbose than writing bash.
There was a problem hiding this comment.
I checked the isaaclab.bat, its checking workflow is good, and also worked with windows, so I think no need for now
StephenWelch
pushed a commit
to StephenWelch/IsaacLab
that referenced
this pull request
Aug 17, 2025
…saac-sim#3139) # Description Current is_isaacsim_version_4_5() sometimes mis-detects 5.0 when running 4.5 (e.g., Docker/symlinked installs), causing the conda bootstrap to pick Python 3.11 instead of 3.10. This pr ensures determining the isaacsim version following below steps 1. Read ${ISAACLAB_PATH}/_isaac_sim/VERSION (symlink/binary install). 2. If unknown, import isaacsim and read ../../VERSION next to the package. (pip installation) 3. If still unknown, fall back to importlib.metadata.version("isaacsim"). I tested locally to work with 4.5 pip or binary install. <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue) ## Screenshots Please attach before and after screenshots of the change if applicable. <!-- Example: | Before | After | | ------ | ----- | | _gif/png before_ | _gif/png after_ | To upload images to a PR -- simply drag and drop an image while in edit mode and it should upload the image directly. You can then paste that source into the above before/after sections. --> ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current is_isaacsim_version_4_5() sometimes mis-detects 5.0 when running 4.5 (e.g., Docker/symlinked installs), causing the conda bootstrap to pick Python 3.11 instead of 3.10.
This pr ensures determining the isaacsim version following below steps
Read ${ISAACLAB_PATH}/_isaac_sim/VERSION (symlink/binary install).
If unknown, import isaacsim and read ../../VERSION next to the package. (pip installation)
If still unknown, fall back to importlib.metadata.version("isaacsim").
I tested locally to work with 4.5 pip or binary install.
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there