Skip to content

Fix for custom dependency install failing due to typo in template generator #3197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

trushant05
Copy link

Description

The template generator is involved when project / task is created using ./isaaclab.sh -n [Project Name]. Inside the source directory in config/extension.toml file there is a provision to add custom apt or ros_ws dependency as mentioned here which is current failing.

The problem is result of a typo in the template generator extension config file which is current [isaaclab_settings] and should be [isaac_lab_settings] instead. The file is located at:

IsaacLab/tools/template/templates/extension/config/extension.toml

Fixes #3196

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Screenshots

Before After
image image

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] Adding dependency in custom extension failing
1 participant