Skip to content

Add export section for residuals and predictions #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 2, 2025

Conversation

JohnnyDoorn
Copy link
Contributor

@JohnnyDoorn JohnnyDoorn commented Apr 16, 2025

@JohnnyDoorn
Copy link
Contributor Author

OK just managed to test it in dev module and for me it works - could you please review @kylelang?

@JohnnyDoorn JohnnyDoorn requested a review from kylelang April 29, 2025 12:46
Copy link

@kylelang kylelang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix for jasp-stats/jasp-issues#2931 looks good.

There are two potential issues that might need to be addressed:

  1. The export option correctly saves raw residuals to the dataset, but jasp-stats/jasp-issues#2989 requested the ability to save standardized residuals. So, I don't think this PR fully satisfies the feature request.
    • Could we add an option in the QML form to allow users to specify which type of residuals they want to save (i.e., raw, standardized, studentized)?
    • Such an option might also be nice to have in jaspRegression.
    • Maybe this isn't an urgent need, and we can merge this PR and add the switch in a future PR.
  2. The test block starting on Line 169 of "test-anovarepeatedmeasuresbayesian.R" is failing with the following error message:

"Error while loading data. Please verify your repeated measures observations."

I'm not sure if these two issues are very important (it looks like the problem with the unit tests was already present before this PR). If the fixes can wait, then I think the PR is good to merge.

@JohnnyDoorn
Copy link
Contributor Author

JohnnyDoorn commented May 1, 2025

Thanks for your time @kylelang!
Let's wait for the tests, but I think i fixed the bayesian unit test.
I also added the option to choose the type of residual (also added it to regression now), but in doing so I realized that saving predictions/residuals for rm anova did not work since it will not be a single column because of the wide data format. For now I just removed the functionality and will return to it later (for the release after hopefully)

@JohnnyDoorn JohnnyDoorn merged commit 0aa5e55 into jasp-stats:master May 2, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants