-
Notifications
You must be signed in to change notification settings - Fork 38
Add geometric and harmonic means #398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good. I still need to run it inside JASP.
76eba5c
to
579a671
Compare
I like the option to have these choices, but one thing I worry about a bit is that now 99% of the users might be confused about which option to choose when they want "the mean". I am also not so well-versed in the different types of means, so can definitely sympathize. Would it be an option to keep calling the arithmetic mean "mean", so indicate that this is the "default" mean? Just like in R, where calling |
Is there a screenshot of what that looks now? |
And we have a tooltip on the the different kinds of means? So the alternative, @JohnnyDoorn, is to have "Mean" underneath "Median", and have this be the arithmetic mean; then the two additions need to be somewhere below. But how would this look, exactly? |
fixes https://github.com/jasp-stats/INTERNAL-jasp/issues/2203