Skip to content

Add geometric and harmonic means #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Kucharssim
Copy link
Member

@Kucharssim Kucharssim requested a review from JohnnyDoorn August 1, 2025 15:53
Copy link
Contributor

@vandenman vandenman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good. I still need to run it inside JASP.

@JohnnyDoorn
Copy link
Contributor

I like the option to have these choices, but one thing I worry about a bit is that now 99% of the users might be confused about which option to choose when they want "the mean". I am also not so well-versed in the different types of means, so can definitely sympathize. Would it be an option to keep calling the arithmetic mean "mean", so indicate that this is the "default" mean? Just like in R, where calling mean() just gives the one type. Then in the infofield (which now also shows up as tooltip), we call it arithmetic mean to specify the type of mean? I think that would keep the interface more userfriendly, while giving the option to users to also calculate different types of means. Anyway just a thought and curious to hear your opinion on this!

@EJWagenmakers
Copy link

Is there a screenshot of what that looks now?

@Kucharssim
Copy link
Member Author

Kucharssim commented Aug 22, 2025

Currently this PR implements it like so (the arithmetic mean is selected by default)

Screenshot 2025-08-22 at 09 13 42

I am not opposed to do it differently if there is a concensus on that

@EJWagenmakers
Copy link

And we have a tooltip on the the different kinds of means? So the alternative, @JohnnyDoorn, is to have "Mean" underneath "Median", and have this be the arithmetic mean; then the two additions need to be somewhere below. But how would this look, exactly?

@Kucharssim
Copy link
Member Author

Screenshot 2025-08-22 at 09 40 30

The help files (and tooltips) do not say much atm, I could add the formulas to make the definitions clearer?

@Kucharssim
Copy link
Member Author

For example, I could add this to the arithmetic mean tooltip

Screenshot 2025-08-22 at 09 49 16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants