Skip to content

Charts #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Charts #1

merged 2 commits into from
Oct 4, 2024

Conversation

josefdc
Copy link
Owner

@josefdc josefdc commented Oct 4, 2024

This pull request includes significant updates to the app.js, index.html, chart.js, and style.css files to enhance the functionality and user experience of the Page Replacement Simulator. The changes include the addition of a performance chart, improvements to the simulation display, and various code refactorings for clarity and efficiency.

Major Enhancements:

Performance Chart Addition:

  • chart.js: Introduced a new script to generate a performance chart using Chart.js, including buttons to show and download the chart.
  • index.html: Added HTML elements for the performance chart section and buttons to interact with the chart.
  • style.css: Added styles for the performance chart section and related buttons.

Simulation Display Improvements:

  • app.js: Refactored the code to remove animation classes and simplify class management for page faults and hits.
  • index.html: Updated the structure and styling of various sections, including input, controls, visualization, and feedback sections.

Code Refactoring and Bug Fixes:

Code Refactoring:

  • app.js: Exposed simulationHistory globally for use in the chart and initialized intervalId to null. [1] [2]
  • app.js: Simplified the generateFeedback function's prompt string.

Bug Fixes:

  • app.js: Fixed a misplaced closing bracket in the interval function to ensure proper simulation step handling.
  • app.js: Removed redundant tooltip-related data attributes and classes.

These changes collectively enhance the functionality, user experience, and maintainability of the Page Replacement Simulator.

@josefdc josefdc merged commit 2c26fb5 into master Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant