Add full support for Laravel Passport 12 #179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Kauto Thanks for the PR, looks like the workflows still fail. Maybe we should consider droping old versions of passport and laravel and just use latest. |
|
@joselfonseca thanks for checking. I maybe fixed the tests. If they still fail I will drop old versions of passport and laravel like you suggested. |
Kauto
force-pushed
the
master
branch
3 times, most recently
from
75bf0d3 to
1520514
Compare
|
It's working for me now. But I had to remove "prefer-lowest" in the test-matrix. |
|
@joselfonseca is everything ok now? |
This was referenced Aug 6, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I combined #172 and #171.
I use the fork of #172 in production since 2 months and it works fine. This PR should fix the missing tests.