Skip to content

Fix error messages and update MysqL client version #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

bertrand-lorentz
Copy link
Contributor

Fix handling of missing required env variable.

This also updates the MysQL client version, as the previous version is not available in the repository anymore, causing "docker build" to fail.

Ensure the error message is displayed correctly when a required env
variable is missing: add missing "echo" command and put the variable
name in simple quotes instead of backticks so that it's not executed as
a command.

Fixes issue joseluisq#1.
The previous version 8.0.42-1debian12 is not available anymore in the
repository.
@joseluisq
Copy link
Owner

This also updates the MysQL client version, as the previous version is not available in the repository anymore, causing "docker build" to fail.

No, the previous version still exists.
See https://repo.mysql.com/apt/debian/pool/mysql-8.0/m/mysql-community/mysql-client_8.0.42-1debian12_amd64.deb

Aside from that, can you please create a new PR for the version update just to track it separately?

@bertrand-lorentz
Copy link
Contributor Author

Thansk for the quick feedback.

I got the following error from "docker build" with the previous version, so I thought I'd handle this in the same PR:

> [ 8/11] RUN set -eux     && DEBIAN_FRONTEND=noninteractive apt-get update -qq     && DEBIAN_FRONTEND=noninteractive apt-get install -qq -y --no-install-recommends         mysql-community-client="8.0.42-1debian12"     && rm -rf /var/lib/apt/lists/*     && rm -rf /var/lib/mysql     && mkdir -p /var/lib/mysql     && chown -R mysql:mysql /var/lib/mysql     && chmod 1777 /var/lib/mysql     && apt-get clean     && rm -rf /var/lib/apt/lists/*     && true:
0.377 + DEBIAN_FRONTEND=noninteractive apt-get update -qq
3.591 + DEBIAN_FRONTEND=noninteractive apt-get install -qq -y --no-install-recommends mysql-community-client=8.0.42-1debian12
4.666 E: Version '8.0.42-1debian12' for 'mysql-community-client' was not found

I'm closing this PR and I'll open 2 new separate PRs, one for each change.

@bertrand-lorentz bertrand-lorentz deleted the fix-error-messages branch August 12, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants