Fix handling of missing required env variable #3
+7
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure the error message is displayed correctly when a required env variable is missing: add missing "echo" command and put the variable name in simple quotes instead of backticks so that it's not executed as a command. Fixes issue joseluisq#1.
joseluisq
added
bug
|
I believe you are right. https://github.com/joseluisq/docker-mysql-client/actions/runs/16909076871/job/47906881204?pr=3#step:6:682 Let's get first #4, then you can sync this PR. |
|
Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure the error message is displayed correctly when a required env variable is missing: add missing "echo" command and put the variable name in simple quotes instead of backticks so that it's not executed as a command.
Fixes issue #1.