Skip to content

Avoid errors in empty files #1358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Avoid errors in empty files #1358

wants to merge 3 commits into from

Conversation

ronisbr
Copy link

@ronisbr ronisbr commented Jul 9, 2025

This commit adds a method to handle the case where the input file is empty. In this case, the expression object is nothing. Without adding this method, an error was thrown.

Closes #1350

@ronisbr
Avoid errors in empty files
664af5b 
This commit adds a method to handle the case where the input file is
empty. In this case, the expression object is `nothing`. Without adding
this method, an error was thrown.

Closes julia-vscode#1350
@ronisbr
Copy link
Author

ronisbr commented Jul 30, 2025

Bump!

fredrikekre
fredrikekre reviewed Jul 31, 2025
View reviewed changes
Copy link
Member

@fredrikekre fredrikekre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is clearer to not call this function if the first argument is nothing?

@ronisbr
Copy link
Author

ronisbr commented Aug 9, 2025

@fredrikekre Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredrikekre fredrikekre fredrikekre left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MethodError while using LSP in Neovim
2 participants
@ronisbr @fredrikekre