Skip to content

Conversation

sakksham7
Copy link
Contributor

@sakksham7 sakksham7 commented Aug 17, 2025

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

#1193

Added a parameter inside layout object, named as mergeSavedMethods, it is an object having structure as

mergeSavedMethods : {
      isMergedSavedMethodsList: bool,
      maxSavedItems: int,
    },

based upon which if there are saved payment methods and isMergedSavedMethodsList is passed as true then instead of coming on a separate saved payment methods screen, it will come in either tabs flow or accordion flow depending upon the layout.
maxSavedItems is used to configure how many saved methods we want to show initially and then the rest can be shown after clicking on show more.

Screen.Recording.2025-08-26.at.4.47.04.PM.mov

How did you test it?

Tested the following cases for both Accordion view and Tabs View :-

  • When saved payment methods are present

  • displaySavedPaymentMethods is false, isMergedSavedMethodsList is false or true No saved payment methods tab

  • displaySavedPaymentMethods is true, isMergedSavedMethodsList is false Normal flow Saved payment methods screen

  • displaySavedPaymentMethods is true, isMergedSavedMethodsList is true Saved payment methods in tabs or accordion

  • When No saved payment methods are present

  • each case will have no saved payment methods

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@sakksham7 sakksham7 self-assigned this Aug 17, 2025
@sakksham7 sakksham7 added the Ready for Review PR with label Ready for Review should only be reviewed. label Aug 17, 2025
Copy link

Review changes with  SemanticDiff

@sakksham7 sakksham7 changed the title feat: unified view for saved payment methods screen and payment metho… feat: unified view for saved and more payment methods screen Aug 17, 2025
aritro2002
aritro2002 previously approved these changes Aug 20, 2025
@vsrivatsa-edinburgh
Copy link
Contributor

Hmm. Quite confusing experience. If “Saved” implies all (saved) payment methods, why should it have a card icon. Right next it to is “Cards” with a card icon again. Worth revisiting

@sakksham7
Copy link
Contributor Author

Hmm. Quite confusing experience. If “Saved” implies all (saved) payment methods, why should it have a card icon. Right next it to is “Cards” with a card icon again. Worth revisiting

Thanks for pointing this out, we’ll revisit the icons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for Review PR with label Ready for Review should only be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combined view for Saved Payment methods screen and payment methods screen
4 participants