Skip to content

Conversation

niksingh710
Copy link
Member

@niksingh710 niksingh710 commented Aug 21, 2025

Resolves: #472 (based on the approach 2 mentioned in #472)
Better/Simpler Implementation of #473.

On MacOs virtual Machine

image

On Ubuntu virtual Machine (Simple Nix installation)

image

@niksingh710 niksingh710 requested a review from Copilot August 21, 2025 17:21
Copilot

This comment was marked as resolved.

@niksingh710 niksingh710 requested a review from Copilot August 21, 2025 18:03
Copilot

This comment was marked as resolved.

@niksingh710 niksingh710 marked this pull request as ready for review August 21, 2025 18:14
Comment on lines 13 to 18
pub enum NixInstallationType {
/// Official Nix installation
Official,
/// Determinate Systems Nix
DeterminateSystems,
}
Copy link
Member

@srid srid Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the right direction, but still doesn't quite capture the nix --version parsing as single action; this command is now being run twice now (as can be seen in your screenshot).

This is a big problem with using LLM to generate code. I'd suggest discarding it and rewriting from scratch as iterating further can be a waste of time.


So which type best captures the output of nix --version? Perhaps something like:

data NixVersion = NixVersion_Official VersionSpec | NixVersion_DetSys { detSysVersion :: VersionSpec, nixVersion :: VersionSpec

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a big problem with using LLM to generate code.

A human can do better here. Types should be modelled based that which they are actually modelling, rather than to fit an existing implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

om health shows false negative against DetSys graphical installer
2 participants