Skip to content

Fix om ci run --override-input broken due to unnecessary flake/ prefix #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix om ci run --override-input broken due to unnecessary flake/ prefix #480

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e78c360
Initial plan
Copilot Aug 25, 2025
72260ef
Remove flake/ prefix transformation from --override-input arguments
Copilot Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 5 additions & 17 deletions crates/nix_rs/src/flake/functions/core.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,24 +105,12 @@ pub trait FlakeFn {
}
}

/// Transform `--override-input` arguments to use `flake/` prefix, which
/// devour_flake expects.
///
/// NOTE: This assumes that Input struct contains a field named exactly "flake" referring to the flake. We should probably be smart about this.
/// Pass through `--override-input` arguments without transformation.
///
/// The `flake/` prefix transformation was removed as of v1.0.0 since it's no longer necessary.
fn transform_override_inputs(args: &[String]) -> Vec<String> {
let mut new_args = Vec::with_capacity(args.len());
let mut iter = args.iter().peekable();

while let Some(arg) = iter.next() {
new_args.push(arg.clone());
if arg == "--override-input" {
if let Some(next_arg) = iter.next() {
new_args.push(format!("flake/{}", next_arg));
}
}
}

new_args
// Simply return args as-is, no flake/ prefix transformation needed
args.to_vec()
}

/// Convert a struct of uniform value types (Option allowed, however) into a vector of fields. The value should be of String kind.
Expand Down
Loading