-
-
Notifications
You must be signed in to change notification settings - Fork 29
Create Angular GitHub Copilot instructions with modern signal-based patterns #1556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@k3nsei 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@copilot You didn't commit any file |
…lopment - Created .github/copilot-instructions.md with detailed guidance for coding agents - Added exception to .gitignore to track the copilot-instructions.md file - Instructions include repository setup, build processes, testing workflows, and troubleshooting - All commands validated and tested with proper timeout recommendations - Includes network workarounds for Cypress and Google Fonts in restricted environments Co-authored-by: k3nsei <190422+k3nsei@users.noreply.github.com>
Fixed! I've now created the comprehensive Commit: 246a04a |
@copilot here are instructions files from angular docs. Use them if it would help. guidelines.md |
…l docs Co-authored-by: k3nsei <190422+k3nsei@users.noreply.github.com>
I've enhanced the copilot instructions with Angular best practices from the official documentation you provided. The updated instructions now include:
This provides comprehensive guidance for any Copilot agent working on this Angular library while maintaining compatibility with the existing codebase. Commit: 1773d5b |
@copilot Ignore the current project standards and patterns, as they are outdated. |
…t best practices Co-authored-by: k3nsei <190422+k3nsei@users.noreply.github.com>
I've completely rewritten the copilot instructions to focus exclusively on Angular v20.2.1 standards and latest best practices, ignoring the current outdated project patterns. The new instructions feature:
This provides comprehensive guidance for Angular v20.2.1 development without being constrained by the current Angular 17 implementation patterns. Commit: 651f5e0 |
@copilot Could you not mention v20.2.1 directly but just as angular and where version is needed refer to it as generic v20+ or >=20.X.Y leave the rest intact |
Co-authored-by: k3nsei <190422+k3nsei@users.noreply.github.com>
Updated the copilot instructions to use generic "Angular" and "v20+" references instead of specific "v20.2.1" versioning. The documentation now uses more future-proof language while maintaining all the modern development patterns and standards. Commit: 29e7d77 |
@copilot can you recreate instructions file from scratch having all the knowledge form previous iterations? I'm still seeing there old patterns and not modern code in code examples. |
…terns Co-authored-by: k3nsei <190422+k3nsei@users.noreply.github.com>
I've completely recreated the instructions file from scratch using pure Angular v20+ patterns. All code examples now use modern APIs like Commit: ee99a5e |
WalkthroughAdds a new repository documentation file with detailed Copilot instructions for an Angular v20+ viewport library and updates .gitignore to ensure the doc is tracked. No source code or public API changes. No build, runtime, or test logic modified. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related issues
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
@copilot fix formatting issues with prettier |
Co-authored-by: k3nsei <190422+k3nsei@users.noreply.github.com>
Fixed formatting issues with prettier. The file now follows proper code style standards with consistent spacing, line breaks, and markdown formatting. Commit: b425e15 Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 15
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
.github/copilot-instructions.md
(1 hunks).gitignore
(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
.github/copilot-instructions.md
92-92: Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
545-545: Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
550-550: Fenced code blocks should be surrounded by blank lines
(MD031, blanks-around-fences)
565-565: Fenced code blocks should be surrounded by blank lines
(MD031, blanks-around-fences)
633-633: Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
642-642: Lists should be surrounded by blank lines
(MD032, blanks-around-lists)
🪛 GitHub Actions: main
.github/copilot-instructions.md
[warning] 1-1: Code style issues found in the file by Prettier. Run 'prettier --write' to fix.
[error] 1-1: Prettier formatting check failed during npm run format. Command 'prettier --check --ignore-unknown .' exited with code 1.
🔇 Additional comments (1)
.gitignore (1)
50-50
: Good: explicit allow-list to track Copilot instructions.The negated rule is in the right place (after the broad
/.github/*
ignores), so the doc will be checked into Git. No complaints.
This PR creates a comprehensive
.github/copilot-instructions.md
file that provides cutting-edge Angular development guidance for GitHub Copilot coding agents, ignoring current outdated project patterns in favor of the latest standards and best practices.Modern Angular v20+ Patterns
The instructions focus exclusively on future-forward Angular development:
input()
,output()
,computed()
, andeffect()
as primary APIs@if
,@for
,@switch
template syntaxsatisfies
operator and strict configurationKey Features
Code Examples
The instructions include complete examples of modern Angular patterns:
This ensures any GitHub Copilot agent working on Angular libraries will use the most modern, performant, and maintainable patterns available in Angular v20+.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.
Summary by CodeRabbit