Skip to content

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Aug 22, 2025

This PR adds Model Context Protocol (MCP) server configuration and implements the https://agents.md/ standard to enhance AI-powered development assistance for the ng-in-viewport Angular library project.

What's Added

MCP Server Configurations

  • Angular CLI MCP - Angular-specific development assistance and component generation
  • GitHub MCP - Repository management, issue tracking, and PR operations
  • Playwright MCP - Browser automation and E2E testing support
  • File System MCP - Project file operations and directory traversal
  • Git MCP - Version control operations and commit history management
  • TypeScript MCP - TypeScript language analysis and code completion
  • Brave Search MCP - Web search capabilities for documentation lookup

Configuration Files

  • .mcprc.json - Main MCP configuration with server definitions and settings
  • mcp.json - Claude Desktop compatible configuration format
  • .vscode/settings.json - Updated VS Code workspace settings with coverage exclusions
  • .vscode/extensions.json - Curated extension recommendations (removed unnecessary extensions)
  • agents.md - AI agent instructions following the https://agents.md/ standard

agents.md Standard Support

The new agents.md file provides comprehensive instructions for AI agents working with this codebase, including:

  • Project architecture and Angular v20+ development guidelines
  • Repository structure and key commands
  • Testing strategies and performance requirements
  • Browser compatibility and SSR considerations
  • Contributing guidelines and common development tasks

Benefits

  • Enhanced Development Experience - AI assistants understand Angular ecosystem and project structure
  • Streamlined Operations - Automated GitHub, Git, and file system operations through MCP servers
  • Standardized AI Guidance - Following https://agents.md/ standard for consistent AI assistance
  • Clean Configuration - Removed unnecessary VS Code extensions for security and focused development
  • Better Testing Support - Enhanced E2E testing and debugging capabilities

The implementation maintains full project compatibility and follows Angular best practices while providing powerful AI development assistance capabilities through industry-standard protocols.

Fixes #1557.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copy link

vercel bot commented Aug 22, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
ng-in-viewport Ready Ready Preview Comment Aug 22, 2025 11:42am

…ght and other useful MCPs

Co-authored-by: k3nsei <190422+k3nsei@users.noreply.github.com>
Co-authored-by: k3nsei <190422+k3nsei@users.noreply.github.com>
@Copilot Copilot AI changed the title [WIP] Add MCP's Add comprehensive MCP configuration for Angular CLI, GitHub, Playwright and other development tools Aug 22, 2025
@Copilot Copilot AI requested a review from k3nsei August 22, 2025 11:26
Copilot finished work on behalf of k3nsei August 22, 2025 11:26
"ms-playwright.playwright",
"github.vscode-github-actions",
"github.copilot",
"github.copilot-chat",
Copy link
Owner

@k3nsei k3nsei Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copilot is shipping with vscode builded-in so it's not needed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed GitHub Copilot extensions from VS Code recommendations as they're now built-in. Changes in commit 35e37c9.

"esbenp.prettier-vscode",
"dbaeumer.vscode-eslint",
"ms-vscode.vscode-typescript-next",
"bradlc.vscode-tailwindcss",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this project isn't using tailwind so it's not needed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed Tailwind CSS extension since the project doesn't use Tailwind. Changes in commit 35e37c9.

"dbaeumer.vscode-eslint",
"ms-vscode.vscode-typescript-next",
"bradlc.vscode-tailwindcss",
"formulahendry.auto-rename-tag"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

avoid using extensions that are not needed to avoid security risks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed auto-rename-tag extension to minimize security risks from unnecessary extensions. Changes in commit 35e37c9.

@@ -0,0 +1,135 @@
# MCP Configuration for ng-in-viewport
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this file it's not needed as MCP's are standard and well understud

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed docs/MCP_SETUP.md file as MCPs are standard and well understood. Changes in commit 35e37c9.

@@ -0,0 +1,104 @@
#!/usr/bin/env node
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no needed to validate mcps

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed scripts/validate-mcp.js file as MCP validation is not needed. Changes in commit 35e37c9.

package.json Outdated
@@ -19,6 +19,7 @@
"lint:demo": "ng lint demo",
"lint:example": "ng lint example",
"lint:lib": "ng lint ng-in-viewport",
"mcp:validate": "node scripts/validate-mcp.js",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove not needed to verify mcps

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed mcp:validate npm script from package.json. Changes in commit 35e37c9.

README.md Outdated
@@ -10,6 +10,7 @@
- 🤓 Learn about it on the [Docs Site][lib-docs]
- 🚀 See it in action on the [Examples Site][example-app]
- 🎮 Play with it on [Stackblitz][example-app-embed]
- 🤖 Enhanced with [MCP Support][mcp-docs] for AI-powered development
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not add mcps docs so rollback changes to README.md

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted README.md changes to remove MCP documentation. Changes in commit 35e37c9.

@k3nsei
Copy link
Owner

k3nsei commented Aug 22, 2025

@copilot Here are you next steps

…d agents.md support

Co-authored-by: k3nsei <190422+k3nsei@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Aug 22, 2025

@copilot Here are you next steps

  • resolve review comments
    ...

All review comments have been resolved and agents.md standard support has been added in commit 35e37c9. The new agents.md file provides comprehensive AI agent instructions following the https://agents.md/ standard.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • download.cypress.io
    • Triggering command: node index.js --exec install (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Co-authored-by: k3nsei <190422+k3nsei@users.noreply.github.com>
@Copilot Copilot AI changed the title Add comprehensive MCP configuration for Angular CLI, GitHub, Playwright and other development tools Add comprehensive MCP configuration and agents.md standard support for AI development assistance Aug 22, 2025
@Copilot Copilot AI requested a review from k3nsei August 22, 2025 11:42
Copilot finished work on behalf of k3nsei August 22, 2025 11:42
@k3nsei k3nsei marked this pull request as ready for review August 22, 2025 13:21
Copy link

coderabbitai bot commented Aug 22, 2025

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Join our Discord community for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@k3nsei k3nsei merged commit e94b09b into develop Aug 22, 2025
6 checks passed
@k3nsei k3nsei deleted the copilot/fix-1557 branch August 22, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add MCP's
2 participants