-
-
Notifications
You must be signed in to change notification settings - Fork 29
Add comprehensive MCP configuration and agents.md standard support for AI development assistance #1558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…ght and other useful MCPs Co-authored-by: k3nsei <190422+k3nsei@users.noreply.github.com>
Co-authored-by: k3nsei <190422+k3nsei@users.noreply.github.com>
.vscode/extensions.json
Outdated
"ms-playwright.playwright", | ||
"github.vscode-github-actions", | ||
"github.copilot", | ||
"github.copilot-chat", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copilot is shipping with vscode builded-in so it's not needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed GitHub Copilot extensions from VS Code recommendations as they're now built-in. Changes in commit 35e37c9.
.vscode/extensions.json
Outdated
"esbenp.prettier-vscode", | ||
"dbaeumer.vscode-eslint", | ||
"ms-vscode.vscode-typescript-next", | ||
"bradlc.vscode-tailwindcss", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this project isn't using tailwind so it's not needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed Tailwind CSS extension since the project doesn't use Tailwind. Changes in commit 35e37c9.
.vscode/extensions.json
Outdated
"dbaeumer.vscode-eslint", | ||
"ms-vscode.vscode-typescript-next", | ||
"bradlc.vscode-tailwindcss", | ||
"formulahendry.auto-rename-tag" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
avoid using extensions that are not needed to avoid security risks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed auto-rename-tag extension to minimize security risks from unnecessary extensions. Changes in commit 35e37c9.
docs/MCP_SETUP.md
Outdated
@@ -0,0 +1,135 @@ | |||
# MCP Configuration for ng-in-viewport |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this file it's not needed as MCP's are standard and well understud
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed docs/MCP_SETUP.md file as MCPs are standard and well understood. Changes in commit 35e37c9.
scripts/validate-mcp.js
Outdated
@@ -0,0 +1,104 @@ | |||
#!/usr/bin/env node |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no needed to validate mcps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed scripts/validate-mcp.js file as MCP validation is not needed. Changes in commit 35e37c9.
package.json
Outdated
@@ -19,6 +19,7 @@ | |||
"lint:demo": "ng lint demo", | |||
"lint:example": "ng lint example", | |||
"lint:lib": "ng lint ng-in-viewport", | |||
"mcp:validate": "node scripts/validate-mcp.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove not needed to verify mcps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed mcp:validate npm script from package.json. Changes in commit 35e37c9.
README.md
Outdated
@@ -10,6 +10,7 @@ | |||
- 🤓 Learn about it on the [Docs Site][lib-docs] | |||
- 🚀 See it in action on the [Examples Site][example-app] | |||
- 🎮 Play with it on [Stackblitz][example-app-embed] | |||
- 🤖 Enhanced with [MCP Support][mcp-docs] for AI-powered development |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do not add mcps docs so rollback changes to README.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted README.md changes to remove MCP documentation. Changes in commit 35e37c9.
@copilot Here are you next steps
|
…d agents.md support Co-authored-by: k3nsei <190422+k3nsei@users.noreply.github.com>
All review comments have been resolved and agents.md standard support has been added in commit 35e37c9. The new agents.md file provides comprehensive AI agent instructions following the https://agents.md/ standard. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Co-authored-by: k3nsei <190422+k3nsei@users.noreply.github.com>
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Join our Discord community for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
This PR adds Model Context Protocol (MCP) server configuration and implements the https://agents.md/ standard to enhance AI-powered development assistance for the ng-in-viewport Angular library project.
What's Added
MCP Server Configurations
Configuration Files
.mcprc.json
- Main MCP configuration with server definitions and settingsmcp.json
- Claude Desktop compatible configuration format.vscode/settings.json
- Updated VS Code workspace settings with coverage exclusions.vscode/extensions.json
- Curated extension recommendations (removed unnecessary extensions)agents.md
- AI agent instructions following the https://agents.md/ standardagents.md Standard Support
The new
agents.md
file provides comprehensive instructions for AI agents working with this codebase, including:Benefits
The implementation maintains full project compatibility and follows Angular best practices while providing powerful AI development assistance capabilities through industry-standard protocols.
Fixes #1557.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.