feat: add VertexAI machine identity support (#477) #710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add GeminiVertexAI and AnthropicVertexAI providers to backend handlers - Implement conditional authentication: ADC when no apiKeySecretRef, explicit credentials otherwise - Add frontend support with provider configurations and TypeScript types - Include comprehensive golden tests for both authentication scenarios - Update Go version to 1.24.0 for compatibility Resolves kagent-dev#477 Signed-off-by: Priyansh Saxena <130545865+Transcendental-Programmer@users.noreply.github.com>
Transcendental-Programmer
requested review from
peterj,
EItanya and
ilackarms
as code owners
EItanya
requested changes
Aug 8, 2025
| @@ -1,6 +1,6 @@ | |||
| module github.com/kagent-dev/kagent/go | |||
|
|
|||
| go 1.24.5 | |||
| go 1.24.0 | |||
There was a problem hiding this comment.
Why this change, we just upgraded to 1.24.6, does that fix things? In general I'm not a fan of downgrading dependencies unless there's a really good reason
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, we support only explicit credentials (via a JSON key) for VertexAI providers. This PR adds support for machine identity (ADC) as well essentially letting the provider authenticate via default credentials when no secret ref is provided.
The core logic in the translator was already set up to conditionally inject the
GOOGLE_APPLICATION_CREDENTIALSenv var only when needed, so most of the work here was wiring up the provider config and ensuring the frontend could handle the new shape.projectIDandlocationas required fields for the VertexAI providers (Gemini + Anthropic)Tested both flows locally and in golden tests, both providers seem to behave as expected now. ADC skips the env var injection entirely, while JSON uses it the same as before. No regressions in existing behavior.
Leaving out screenshots since this is mostly backend/auth-related.
Still ironing out some edge cases, but this should be safe to merge once reviewed.
Fixes #477.