-
Notifications
You must be signed in to change notification settings - Fork 243
[CLEANUP] Remove Memory sections from UI following v1alpha2 API migration #752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! To fix the DCO issue, see the instructions here. Also, since this is from a fork, go to your repo's Settings and add an env variable called OPENAI_API_KEY with an openai key so that the e2e tests will pass.
9647425
to
e1c0f32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be a broken reference to setSelectedMemories that still exists in the code
Thank you so much @ashleywang1, for the feedback. I will fix it as soon as possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you able to run make build-ui
locally? That should help you iterate through the failing tests here.
Thanks @ashleywang1 for the suggestion to run |
If you can't install docker, you can run |
Thank you @peterj for the guidance!, I've ran these commands. On running this
and on running
|
there are still build issues -- can you please check? (also, the |
d067484
to
fe4aeeb
Compare
please make sure you sign the DCO |
0785519
to
fefd3b9
Compare
Thank you, @peterj. I have removed the MemorySelectionSection.tsx and signed the DCO. Please let me know if anything needs to be improved further. |
@tanuj-rai - something might've messed up during the merge because I now see go/controller changes in this PR |
Hi @ashleywang1, Apologies for the unintended |
I’m really sorry @peterj, for the mess caused by changes in go/controller. I really want to fix this properly. It will be ok if I clean up this branch so the PR only includes the intended UI changes, or should I open a fresh PR with the correct commits? |
That's totally up to you! Whichever is easier |
c0f0ba1
to
2e8f30a
Compare
Signed-off-by: Tanuj-rai <tanujrai898@gmail.com>
2e8f30a
to
7d3ce9a
Compare
ui/src/app/agents/new/page.tsx
Outdated
byoImage: string; | ||
byoCmd: string; | ||
byoArgs: string; | ||
replicas: string; | ||
imagePullPolicy: string; | ||
imagePullSecrets: string[]; | ||
envPairs: { name: string; value?: string; isSecret?: boolean; secretName?: string; secretKey?: string; optional?: boolean }[]; | ||
envPairs: { key: string; value: string }[]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this doesn't look like the latest code either
@tanuj-rai looks like some changes are unnecessary and/or you haven't synced from the latest main. Try fetching the latest main and then rebasing it onto your branch. (Alternatively, start from scratch as there shouldn't be too many places to remove the memory concepts from). |
Signed-off-by: Tanuj Rai <tanujrai19@gmail.com>
Signed-off-by: Tanuj Rai <tanujrai19@gmail.com>
Signed-off-by: Tanuj Rai <tanujrai19@gmail.com>
Signed-off-by: Tanuj Rai <tanujrai19@gmail.com>
Signed-off-by: Tanuj Rai <tanujrai19@gmail.com>
Signed-off-by: Tanuj Rai <tanujrai19@gmail.com>
Signed-off-by: Tanuj Rai <tanujrai19@gmail.com>
Signed-off-by: Tanuj Rai <tanujrai19@gmail.com>
Signed-off-by: Tanuj Rai <tanujrai19@gmail.com>
This PR removes all memory-related functionality from the UI as part of the v1alpha2 API migration.
1. Memory Pages/Routes:
-Removed memory listing page (/memories)
-Removed memory creation page (/memories/new)
2. Agent Creation / Edit Forms:
-Removed memory selection section from ui/src/app/agents/new/page.tsx
-Removed memory references from ui/src/components/AgentDetailsSidebar.tsx
-Cleaned up imports
3. Agent Display Components:
-Cleaned up AgentDetailsSidebar
4. Navigation & Routing:
-Removed memory navigation items
5. Types & Interfaces:
-Removed MemoryResponse, CreateMemoryRequest, and UpdateMemoryRequest types
-Deleted API client methods for memory
Fixes: issue #738
Who can review:
@ashleywang1 @peterj