feat: make agents to be able include all tools from mcp tool server #753
+136
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EItanya
reviewed
Aug 14, 2025
| @@ -109,7 +109,7 @@ type McpServerTool struct { | |||
| // The names of the tools to be provided by the ToolServer | |||
| // For a list of all the tools provided by the server, | |||
| // the client can query the status of the ToolServer object after it has been created | |||
| ToolNames []string `json:"toolNames,omitempty"` | |||
| ToolNames []string `json:"toolNames"` | |||
There was a problem hiding this comment.
Why did you remove omitEmpty? This just makes the field required. Now you would have to put toolNames: []. Is that intentional?
There was a problem hiding this comment.
Why did you remove
omitEmpty? This just makes the field required. Now you would have to puttoolNames: []. Is that intentional?
Yes, it's intentional as I made [] to be equal to include all tools from mcp server
to agent, i guess it might not be the optimal or line-up with yours
architecture, so I'm seeking for the advice how to line-up that feature
with it. As it might be pretty useful for small tool servers, and with
automating binding tools/toolservers to the agent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow agents to automatically include all tools from an MCP Tool Server, simplifying configuration and ensuring new tools are available without manual updates.