Skip to content

Remove deprecated toolserver CRD from kagent-crds helm chart #783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

antweiss
Copy link

As the ToolServer api has been removed - the CRD is redundant and is just causing confusion

EItanya
EItanya previously approved these changes Aug 20, 2025
Copy link
Contributor

@EItanya EItanya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@EItanya EItanya dismissed their stale review August 20, 2025 19:51

I forgot it also needs to be removed from go/config/crd/bases

@EItanya
Copy link
Contributor

EItanya commented Aug 20, 2025

Thanks so much for the PR, and a great catch. Unfortunately this will not work today. These CRDs are autogenerated from the go types, which still exist. go/controller/api/v1alpha1. You'll need to figure out how to get it to stop generating this CR

@antweiss
Copy link
Author

antweiss commented Aug 20, 2025 via email

@antweiss
Copy link
Author

So, there's a way to avoid generating all CRs for v1alpha1 by adding the // +kubebuilder:skip directive on the v1alpha1 package. This will also remove the deprecated Memories CR. The question is - do we need older versions?

@antweiss
Copy link
Author

@EItanya I updated the PR so that all v1alpha1 CRs are skipped while generating. I believe this is ok at this stage of the project but I could be wrong. LMKWYT

@EItanya
Copy link
Contributor

EItanya commented Aug 21, 2025

It should be fine, however there is one situation I am worried about. Do upgrades from 0.5.x -> this commit work properly after this change. I remember seeing issues upgrading CRDs when removing versions like this, but I may have been doing it wrong. I think if it fails we should wait until 0.7.x to remove them completely.

What do you think?

@antweiss
Copy link
Author

I think I'll give it a try. Will install CRDs from the old chart and then upgrade to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants