-
Notifications
You must be signed in to change notification settings - Fork 244
Remove deprecated toolserver CRD from kagent-crds helm chart #783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
I forgot it also needs to be removed from go/config/crd/bases
Thanks so much for the PR, and a great catch. Unfortunately this will not work today. These CRDs are autogenerated from the go types, which still exist. |
Thanks! I believe I know how to do it. Will look into it tomorrow.
Anton Weiss
http://otomato.io
…On Wed, Aug 20, 2025, 10:53 PM Eitan Yarmush ***@***.***> wrote:
*EItanya* left a comment (kagent-dev/kagent#783)
<#783 (comment)>
Thanks so much for the PR, and a great catch. Unfortunately this will not
work today. These CRDs are autogenerated from the go types, which still
exist. go/controller/api/v1alpha1. You'll need to figure out how to get
it to stop generating this CR
—
Reply to this email directly, view it on GitHub
<#783 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAY7P3UQTY7PSX2NE7HWUAL3OTG27AVCNFSM6AAAAACEMM2DIWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTEMBXHA4DAMBVHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
So, there's a way to avoid generating all CRs for v1alpha1 by adding the // +kubebuilder:skip directive on the v1alpha1 package. This will also remove the deprecated Memories CR. The question is - do we need older versions? |
@EItanya I updated the PR so that all v1alpha1 CRs are skipped while generating. I believe this is ok at this stage of the project but I could be wrong. LMKWYT |
It should be fine, however there is one situation I am worried about. Do upgrades from What do you think? |
I think I'll give it a try. Will install CRDs from the old chart and then upgrade to this. |
As the ToolServer api has been removed - the CRD is redundant and is just causing confusion