Skip to content

Add a curses-based console #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

TellowKrinkle
Copy link

The current console flickers every time it's updated, while curses doesn't

Automatically falls back to the old console if curses isn't installed

@generalmimon
Copy link
Member

Any volunteers to review this? Cc @GreyCat, @abitrolly, @ams-tschoening, @dgelessus, @LogicAndTrick

@abitrolly
Copy link
Contributor

Pass. My relationship with curses and the way linux terminal works are far from ideal.

@ams-tschoening
Copy link
Contributor

I don't have a properly set-up Linux test system at all, but tested the PR on Windows and things still work like before. So from that point I'm fine with merging. :-)

@abitrolly
Copy link
Contributor

No review, but I guess I can still run this on Linux later. I thought that the curses is the only way to do "graphical" stuff in terminal. :>

If there is any value in previous implementation, maybe it is worth to describe the differences and add a tag. If maintaining both implementation will become a burden, there will be at least some arguments.

@generalmimon
Copy link
Member

Hmm, this actually doesn't look nearly as hard to review as it once did...

Maybe I'll look into it someday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants