-
Notifications
You must be signed in to change notification settings - Fork 3
Fix README docker link #474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
Fix 404 error on link to docker image
WalkthroughThe README.md was updated to correct Docker container links by removing URL-encoded path segments, changing base-repo%2Fbase-repo to base-repo in two sections. No code, configuration, or behavior changes were made. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
README.md (1)
104-104
: Optional: add a copy-paste Docker pull/run snippetConsider adding a short example to help users quickly pull the image:
# Pull from GitHub Container Registry docker pull ghcr.io/kit-data-manager/base-repo:latest # Run (adjust ports/env as needed) docker run --rm -p 8080:8080 ghcr.io/kit-data-manager/base-repo:latest
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
README.md
(1 hunks)
🔇 Additional comments (1)
README.md (1)
104-104
: LGTM: broken Docker link fixedThe container link now correctly points to github.com/kit-data-manager/base-repo/pkgs/container/base-repo and resolves the 404. Good catch.
@@ -101,7 +101,7 @@ What you now have to do before you start the microservice is to place additional | |||
|
|||
* [Getting Started & Documentation](https://kit-data-manager.github.io/webpage/base-repo/index.html) | |||
* [API documentation](https://kit-data-manager.github.io/webpage/base-repo/documentation/api-docs.html) | |||
* [Docker container](https://github.com/kit-data-manager/base-repo/pkgs/container/base-repo%2Fbase-repo) | |||
* [Docker container](https://github.com/kit-data-manager/base-repo/pkgs/container/base-repo) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
❓ Verification inconclusive
Summary mismatch: only one visible change
The AI summary mentions two locations updated; the annotated diff shows a single changed line. Please confirm whether the badge link earlier in the README was also changed in this PR or was already correct.
You can verify remaining occurrences of the old, URL-encoded path with:
🏁 Script executed:
#!/bin/bash
# Find any lingering encoded references in the repo
rg -n "base-repo%2Fbase-repo|pkgs/container/base-repo%2Fbase-repo" -S
Length of output: 71
Correction: only one Docker container link updated
The only change in this PR is the Docker container link at README.md:104—no earlier badge link was modified and no URL-encoded paths remain. Please update the PR summary to reflect that a single link was updated.
- Location needing summary update: README.md line 104
🤖 Prompt for AI Agents
In README.md around line 104, the PR summary incorrectly suggests multiple
badge/link changes; the only change is the Docker container link. Update the PR
summary (or PR description) to state that a single Docker container link at
README.md:104 was updated, remove any mention of other badge or URL-encoded path
changes, and ensure the summary references the exact file and line (README.md
line 104) for clarity.
Link initially contained an escaped slash, resulting in a 404 error
Afaik package has been moved from base-repo/base-repo to base-repo. Link reflects that now.
Summary by CodeRabbit