Override crs in imported tiles #1061
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1060 When --override-crs is given for raster or pointcloud import, the tiles need to be rewritten (using PDAL or GDAL) to override the CRS (as well as setting the CRS in the dataset meta). This change does that.
craigds
force-pushed
the
override-crs-in-laz-files
branch
from
48f6e58 to
f483b24
Compare
craigds
commented
Aug 25, 2025
| return convert_tile_to_copc | ||
| return None | ||
|
|
||
| def existing_tile_matches_source(self, source_oid, existing_summary): | ||
| """Check if the existing tile can be reused instead of reimporting.""" | ||
| # If override_crs is specified, we need to rewrite the CRS in the files, | ||
| # so we can't reuse existing tiles |
There was a problem hiding this comment.
there's actually at least a minor issue here - if you import the same files multiple times, each time with the same --override-crs, this will import all tiles again each time, which is unnecessary.
I'm wondering if we should be checking the CRS of the previous tile itself here (or we could check the CRS of the previous dataset and assume it matches the previous tile, which is much cheaper esp if the tiles are on LFS). If the previous dataset/tile matches the override, we can possibly return True here (if the sourceOID matches)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When --override-crs is given for raster or pointcloud import, the tiles need to be rewritten (using PDAL or GDAL) to override the CRS (as well as setting the CRS in the dataset meta). This change does that.
Related links:
Fixes #1060
Checklist: