set-labels: added support for sourcing label values from other resources #914
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for specifying label values from fields in the other resources in the package.
An example setlabel configuration where we add
myapp
label and value comes fromdata.name
field in package-context.yaml.Note the
labelsFrom
. This change is also backward compatible sincelabelsFrom
is new field./cc @yuwenma @natasha41575
Note: I tested this manually. Will add tests if y'all agree with the direction.