Fix CRI-O related runtime binary path #2361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
approved
JAORMX
approved these changes
Jul 17, 2024
k8s-ci-robot
added
the
lgtm
|
/lgtm cancel |
k8s-ci-robot
removed
the
lgtm
|
It LGTM, but let's see why the test is failing. |
|
Yeah I'm investigating. |
k8s-ci-robot
added
size/S
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2361 +/- ##
==========================================
- Coverage 45.50% 42.09% -3.42%
==========================================
Files 79 109 +30
Lines 7782 15870 +8088
==========================================
+ Hits 3541 6680 +3139
- Misses 4099 8696 +4597
- Partials 142 494 +352 |
The binaries are now under `/usr/libexec/crio` instead of `crio-*` prefixed. We now fix those paths to make the CI work again. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
|
@JAORMX CI is ready |
|
niiice, let's go! /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JAORMX, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
The binaries are now under
/usr/libexec/crioinstead ofcrio-*prefixed. We now fix those paths to make the CI work again.Which issue(s) this PR fixes:
None
Does this PR have test?
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?