Skip to content

OCPBUGS-60139: Fix profilerecording failed to create selinuxprofile issue #2953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

xiaojiey
Copy link
Contributor

@xiaojiey xiaojiey commented Aug 11, 2025

What type of PR is this?

/kind bug

Optionally add one or more of the following kinds if applicable:
/kind regression

What this PR does / why we need it:

OCPBUGS-60139

Which issue(s) this PR fixes:

Does this PR have test?

Special notes for your reviewer:

Does this PR introduce a user-facing change?


@k8s-ci-robot k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Aug 11, 2025
Copy link

linux-foundation-easycla bot commented Aug 11, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: xiaojiey / name: Xiaojie Yuan (6356f68)

@k8s-ci-robot
Copy link
Contributor

Welcome @xiaojiey!

It looks like this is your first PR to kubernetes-sigs/security-profiles-operator 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/security-profiles-operator has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 11, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @xiaojiey. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 11, 2025
@xiaojiey xiaojiey changed the title Fix profilerecording failed to create selinuxprofile issue OCPBUGS-60139: Fix profilerecording failed to create selinuxprofile issue Aug 11, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 11, 2025
@saschagrunert
Copy link
Member

Thank you for the contribution @xiaojiey! 🙏 Do you mind signing the CLA?

@xiaojiey
Copy link
Contributor Author

Thank you for the contribution @xiaojiey! 🙏 Do you mind signing the CLA?

Done. Thanks.

@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2025

Codecov Report

❌ Patch coverage is 38.46154% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 26.46%. Comparing base (11d77f4) to head (6356f68).
⚠️ Report is 966 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2953       +/-   ##
===========================================
- Coverage   45.50%   26.46%   -19.04%     
===========================================
  Files          79      125       +46     
  Lines        7782    20901    +13119     
===========================================
+ Hits         3541     5531     +1990     
- Misses       4099    15086    +10987     
- Partials      142      284      +142     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xiaojiey xiaojiey force-pushed the fix-selinx-profilerecording branch from 73d3266 to db048e6 Compare August 12, 2025 13:26
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 12, 2025
@Vincent056
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 13, 2025
@Vincent056
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 13, 2025
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2025
@saschagrunert
Copy link
Member

/release-note-none

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Aug 13, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Aug 13, 2025
@xiaojiey
Copy link
Contributor Author

/test e2e-ubuntu

@k8s-ci-robot
Copy link
Contributor

@xiaojiey: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-security-profiles-operator-build
/test pull-security-profiles-operator-build-image
/test pull-security-profiles-operator-test-e2e
/test pull-security-profiles-operator-test-unit
/test pull-security-profiles-operator-verify

Use /test all to run all jobs.

In response to this:

/test e2e-ubuntu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@xiaojiey
Copy link
Contributor Author

/test pull-security-profiles-operator-test-e2e

@xiaojiey
Copy link
Contributor Author

/test all

2 similar comments
@xiaojiey
Copy link
Contributor Author

/test all

@xiaojiey
Copy link
Contributor Author

/test all

@saschagrunert
Copy link
Member

@xiaojiey please rebase

@xiaojiey xiaojiey force-pushed the fix-selinx-profilerecording branch from db048e6 to 6356f68 Compare August 20, 2025 01:37
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 20, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 20, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert, Vincent056, xiaojiey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 632feeb into kubernetes-sigs:main Aug 20, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants