-
Notifications
You must be signed in to change notification settings - Fork 123
Add a delay and check to ensure that SPOD patch is rolled out #2964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a delay and check to ensure that SPOD patch is rolled out #2964
Conversation
Hi @ngopalak-redhat. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2964 +/- ##
===========================================
- Coverage 45.50% 26.44% -19.07%
===========================================
Files 79 126 +47
Lines 7782 21051 +13269
===========================================
+ Hits 3541 5566 +2025
- Misses 4099 15203 +11104
- Partials 142 282 +140 🚀 New features to boost your workflow:
|
/ok-to-test |
@ngopalak-redhat do you mind a rebase? |
82e92a5
to
fbab50f
Compare
@saschagrunert I have done the rebase. Initially tried via the UI to sync the branch and it added "contains-merge-commit" label. Best way was to rebase using the cli which fixed the issue. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ngopalak-redhat, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR fixes an intermittent failure in the e2e tests for seccomp-profile.
This was observed in https://github.com/kubernetes-sigs/security-profiles-operator/actions/runs/16961101889/job/48074161956?pr=2958
The issue occurred because a test assumed the SPOD object's changes had been applied to the DaemonSet before the SPO controller had time to execute. The controller, which takes a moment or two to run (Many a time less than a second), is responsible for modifying the DaemonSet. This timing discrepancy caused the rollout status check to fail because it ran before the changes were complete.
Which issue(s) this PR fixes:
Does this PR have test?
Yes, the successful multiple runs of the e2etest.
Special notes for your reviewer:
Does this PR introduce a user-facing change?