Skip to content

Bump Cairo and Rust dependencies #1361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Aug 19, 2025
Merged

Bump Cairo and Rust dependencies #1361

merged 20 commits into from
Aug 19, 2025

Conversation

JulianGCalderon
Copy link
Contributor

@JulianGCalderon JulianGCalderon commented Aug 14, 2025

  • Bumps Cairo dependencies to 2.12.0. This implies:
    • Adding some new type/libfunc variants.
    • Modifying the corelib patch.
  • Bumps Rust toolchain to 1.89.
    • This implies fixing some new clippy lints.

Closes #1360

Copy link

github-actions bot commented Aug 14, 2025

Benchmarking results

Benchmark for program dict_insert

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 10.385 ± 0.034 10.349 10.472 4.27 ± 0.03
cairo-native (embedded AOT) 2.434 ± 0.016 2.411 2.459 1.00
cairo-native (embedded JIT using LLVM's ORC Engine) 2.517 ± 0.010 2.503 2.531 1.03 ± 0.01

Benchmark for program dict_snapshot

Open benchmarks
Command Mean [ms] Min [ms] Max [ms] Relative
Cairo-vm (Rust, Cairo 1) 516.7 ± 2.6 512.4 521.0 1.00
cairo-native (embedded AOT) 2127.1 ± 13.9 2108.0 2159.0 4.12 ± 0.03
cairo-native (embedded JIT using LLVM's ORC Engine) 2222.7 ± 9.3 2207.8 2234.3 4.30 ± 0.03

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 4.600 ± 0.031 4.576 4.683 1.78 ± 0.03
cairo-native (embedded AOT) 2.584 ± 0.038 2.536 2.669 1.00
cairo-native (embedded JIT using LLVM's ORC Engine) 2.598 ± 0.017 2.581 2.638 1.01 ± 0.02

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 4.514 ± 0.010 4.496 4.531 2.16 ± 0.02
cairo-native (embedded AOT) 2.092 ± 0.015 2.075 2.122 1.00
cairo-native (embedded JIT using LLVM's ORC Engine) 2.135 ± 0.013 2.115 2.158 1.02 ± 0.01

Benchmark for program linear_search

Open benchmarks
Command Mean [ms] Min [ms] Max [ms] Relative
Cairo-vm (Rust, Cairo 1) 554.6 ± 4.4 548.2 560.9 1.00
cairo-native (embedded AOT) 2183.5 ± 20.9 2159.6 2233.0 3.94 ± 0.05
cairo-native (embedded JIT using LLVM's ORC Engine) 2304.1 ± 3.7 2299.4 2312.0 4.15 ± 0.03

Benchmark for program logistic_map

Open benchmarks
Command Mean [ms] Min [ms] Max [ms] Relative
Cairo-vm (Rust, Cairo 1) 374.7 ± 5.7 368.8 385.8 1.00
cairo-native (embedded AOT) 2250.1 ± 9.7 2238.6 2272.5 6.01 ± 0.10
cairo-native (embedded JIT using LLVM's ORC Engine) 2428.1 ± 14.4 2405.0 2453.3 6.48 ± 0.11

Copy link

github-actions bot commented Aug 14, 2025

Benchmark results Main vs HEAD.

Base

Command Mean [s] Min [s] Max [s] Relative
base dict_insert.cairo (JIT) 5.373 ± 0.084 5.293 5.550 1.01 ± 0.02
base dict_insert.cairo (AOT) 5.311 ± 0.056 5.195 5.402 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head dict_insert.cairo (JIT) 2.819 ± 0.027 2.777 2.858 1.03 ± 0.01
head dict_insert.cairo (AOT) 2.729 ± 0.022 2.697 2.761 1.00

Base

Command Mean [s] Min [s] Max [s] Relative
base dict_snapshot.cairo (JIT) 5.159 ± 0.067 5.048 5.282 1.04 ± 0.02
base dict_snapshot.cairo (AOT) 4.981 ± 0.039 4.923 5.045 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head dict_snapshot.cairo (JIT) 2.507 ± 0.040 2.448 2.580 1.05 ± 0.02
head dict_snapshot.cairo (AOT) 2.390 ± 0.038 2.317 2.452 1.00

Base

Command Mean [s] Min [s] Max [s] Relative
base factorial_2M.cairo (JIT) 5.508 ± 0.043 5.455 5.598 1.03 ± 0.01
base factorial_2M.cairo (AOT) 5.344 ± 0.036 5.311 5.438 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head factorial_2M.cairo (JIT) 2.869 ± 0.025 2.833 2.903 1.01 ± 0.02
head factorial_2M.cairo (AOT) 2.832 ± 0.059 2.776 2.953 1.00

Base

Command Mean [s] Min [s] Max [s] Relative
base fib_2M.cairo (JIT) 4.962 ± 0.048 4.893 5.029 1.00
base fib_2M.cairo (AOT) 4.970 ± 0.077 4.860 5.109 1.00 ± 0.02

Head

Command Mean [s] Min [s] Max [s] Relative
head fib_2M.cairo (JIT) 2.379 ± 0.022 2.343 2.415 1.01 ± 0.01
head fib_2M.cairo (AOT) 2.355 ± 0.027 2.301 2.401 1.00

Base

Command Mean [s] Min [s] Max [s] Relative
base linear_search.cairo (JIT) 5.160 ± 0.066 5.069 5.247 1.04 ± 0.01
base linear_search.cairo (AOT) 4.967 ± 0.028 4.925 5.032 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head linear_search.cairo (JIT) 2.582 ± 0.031 2.540 2.629 1.08 ± 0.02
head linear_search.cairo (AOT) 2.391 ± 0.022 2.359 2.424 1.00

Base

Command Mean [s] Min [s] Max [s] Relative
base logistic_map.cairo (JIT) 5.225 ± 0.022 5.186 5.259 1.04 ± 0.01
base logistic_map.cairo (AOT) 5.002 ± 0.013 4.977 5.020 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head logistic_map.cairo (JIT) 2.698 ± 0.073 2.619 2.860 1.08 ± 0.03
head logistic_map.cairo (AOT) 2.506 ± 0.020 2.461 2.529 1.00

@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2025

Codecov Report

❌ Patch coverage is 13.95349% with 37 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.49%. Comparing base (88a5f54) to head (5a6df75).

Files with missing lines Patch % Lines
src/debug.rs 0.00% 26 Missing ⚠️
src/types.rs 0.00% 7 Missing ⚠️
src/libfuncs.rs 0.00% 2 Missing ⚠️
src/executor.rs 0.00% 1 Missing ⚠️
src/values.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1361      +/-   ##
==========================================
- Coverage   79.16%   76.49%   -2.68%     
==========================================
  Files         111      111              
  Lines       30440    26408    -4032     
==========================================
- Hits        24099    20201    -3898     
+ Misses       6341     6207     -134     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JulianGCalderon JulianGCalderon marked this pull request as ready for review August 14, 2025 21:16
@gabrielbosio gabrielbosio added this pull request to the merge queue Aug 19, 2025
Merged via the queue into main with commit 8859af8 Aug 19, 2025
30 checks passed
@gabrielbosio gabrielbosio deleted the bump-cairo-deps branch August 19, 2025 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump Cairo dependencies to 2.12.0
5 participants