fix(l1,l2): update test data genesis files with missing contracts #2418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrchatruc
approved these changes
Apr 8, 2025
tomip01
approved these changes
Apr 9, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 10, 2025
**Motivation** In #2418 the genesis-l1-dev.json test file is edited, adding trailing commas. This causes the L2 integration test to fail with: ``` thread 'main' panicked at cmd/ethrex/utils.rs:59:40: Failed to decode genesis file: Error("trailing comma", line: 36, column: 5) ``` **Description** Removes both instances of trailing commas in genesis-l1-dev.json
pedrobergamini
pushed a commit
to pedrobergamini/ethrex
that referenced
this pull request
Aug 24, 2025
…mbdaclass#2418) **Description** We have some genesis files under `test_data` directory which are used on unit tests. This PR: - Fixes the address of the EIP-2935 system contract on some of the genesis files. - Adds the EIP-4788, EIP-7002, EIP-7251 and deposits contract to those same genesis files These contracts are not being used in the unit tests, so this addition is only for consistency.
pedrobergamini
pushed a commit
to pedrobergamini/ethrex
that referenced
this pull request
Aug 24, 2025
**Motivation** In lambdaclass#2418 the genesis-l1-dev.json test file is edited, adding trailing commas. This causes the L2 integration test to fail with: ``` thread 'main' panicked at cmd/ethrex/utils.rs:59:40: Failed to decode genesis file: Error("trailing comma", line: 36, column: 5) ``` **Description** Removes both instances of trailing commas in genesis-l1-dev.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have some genesis files under
test_datadirectory which are used on unit tests.This PR:
These contracts are not being used in the unit tests, so this addition is only for consistency.