perf(l1,l2): use the new load test for the CI scripts #2467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines of code reportTotal lines added: Detailed view |
Arkenan
changed the title
fkrause98
approved these changes
Apr 16, 2025
Oppen
reviewed
Apr 18, 2025
| # By default ethrex uses revm as evm backend. | ||
| - id: generate-flamegraph-ethrex | ||
| name: Generate Flamegraph data for Ethrex | ||
| shell: bash | ||
| run: | | ||
| rm -rf target/release/ethrex | ||
| cargo build --release --bin ethrex --features dev |
There was a problem hiding this comment.
I think you'll get better results building with:
Suggested change
| cargo build --release --bin ethrex --features dev | |
| cargo build --profile release-with-debug --bin ethrex --features dev |
Oppen
reviewed
Apr 18, 2025
| echo "Waiting for ethrex binary to be ready..." | ||
| sleep 2 | ||
| done | ||
| --bin ethrex --release --features dev -- \ |
jrchatruc
approved these changes
Apr 21, 2025
pedrobergamini
pushed a commit
to pedrobergamini/ethrex
that referenced
this pull request
Aug 24, 2025
Changes: - Flamegraph Watcher srcript now: - Uses the new load test. - Fails if any line fails (e.g. the load test binary panics). - CI: - The flamegraphs are now updated on push to main again. - Compilation and running is separated to delete the "while not compiled" polling. - Reth version is pinned so it does not rely on 2024 features and can be compiled again. - Load test: - `make` targets now run in release mode. - now waits until all transactions are included before exciting. There's a flag to set a timeout. - All ethrex_l2 references are deleted from CI and the watcher. Closes lambdaclass#2466
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
maketargets now run in release mode.Closes #2466