feat(l1): dynamically increase storage rebuild parallelization #2469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_ethereum_rust into improve-rebuild-speed
This reverts commit 7bc7f02.
|
This did not produce the expected speedup and yielded regressions instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #2447
Motivation
Currently, storage rebuilding is taking a long time. As each rebuild is independent we can use parallelism to speed it up. There is a limit on how much we can push parallelism before affecting other processes. This upper limit becomes a bit more forgiving once state sync is over, as state sync also uses parallelism and more resources will be available once it is over.
This PR aims to increase storage rebuild speed once state sync is over by increasing parallelism by a constant factor
Description
STATE_SYNC_FINISHED_PARALLELIZATION_FACTORMAX_PARALLEL_REBUILDSby the new constant once state sync is overCloses #issue_number