refactor(l2): Remove redundant address derivation function in load_test #2494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please fix ci |
GarmashAlex
changed the title
GarmashAlex
changed the title
tomip01
approved these changes
Apr 25, 2025
avilagaston9
approved these changes
Apr 25, 2025
Co-authored-by: Tomás Paradelo <112426153+tomip01@users.noreply.github.com>
|
@tomip01 corrected |
|
@mpaulucci Everyting is fixed, i ran tests and now it must be okay, sorry for late review |
avilagaston9
requested changes
May 13, 2025
|
@avilagaston9 corrected |
tomip01
approved these changes
May 14, 2025
avilagaston9
approved these changes
May 14, 2025
fmoletta
pushed a commit
that referenced
this pull request
May 15, 2025
…st (#2494) **Motivation** This pull request addresses a TODO comment in the load_test code that suggested moving the custom address derivation function to common utilities. Instead of duplicating functionality, we should leverage existing code from the SDK to improve maintainability and consistency across the codebase. **Description** This PR removes a redundant implementation of Ethereum address derivation in the load_test tool by replacing it with the existing get_address_from_secret_key function from the L2 SDK. The changes include: - Removed the custom address_from_pub_key function that was marked with a TODO comment - Added an import for get_address_from_secret_key from ethrex_l2_sdk - Updated all usages throughout the code to use the SDK function instead - Added proper error handling for the SDK function calls --------- Co-authored-by: Tomás Paradelo <112426153+tomip01@users.noreply.github.com> Co-authored-by: Martin Paulucci <martin.c.paulucci@gmail.com> Co-authored-by: Tomás Arjovsky <tomas.arjovsky@lambdaclass.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This pull request addresses a TODO comment in the load_test code that suggested moving the custom address derivation function to common utilities. Instead of duplicating functionality, we should leverage existing code from the SDK to improve maintainability and consistency across the codebase.
Description
This PR removes a redundant implementation of Ethereum address derivation in the load_test tool by replacing it with the existing get_address_from_secret_key function from the L2 SDK. The changes include: