Skip to content

fix(l1): blob transaction init for revm ef tests #2588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 28, 2025
Merged

fix(l1): blob transaction init for revm ef tests #2588

merged 6 commits into from
Apr 28, 2025

Conversation

cdiielsi
Copy link
Contributor

@cdiielsi cdiielsi commented Apr 24, 2025 •
edited
Loading

Motivation

Fixing REVM tests as specified in issue #2491.

Description

This pr changes the blob_excess_gas_and_price variable initialization in the prepare_revm_for_tx function. Now instead of setting gas price in 0 I use the new function associated to the BlobExcessGasAndPrice struct that sets the gas price by itself with a particular function that calculates it.

This change drops the failing amount of tests from 2009 to 829.

This pr solves part of the issue #2491.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 24, 2025 •
edited
Loading

Lines of code report

Total lines added: 0
Total lines removed: 3
Total lines changed: 3

Detailed view 
+-------------------------------------------------+-------+------+
| File                                            | Lines | Diff |
+-------------------------------------------------+-------+------+
| ethrex/cmd/ef_tests/state/runner/revm_runner.rs | 511   | -3   |
+-------------------------------------------------+-------+------+

@cdiielsi cdiielsi changed the title flag for filtering not failing tests on execution fix: blob transaction init for revm ef tests Apr 28, 2025
@cdiielsi cdiielsi changed the title fix: blob transaction init for revm ef tests fix: l1 blob transaction init for revm ef tests Apr 28, 2025
@cdiielsi cdiielsi changed the title fix: l1 blob transaction init for revm ef tests fix(l1): blob transaction init for revm ef tests Apr 28, 2025
@cdiielsi cdiielsi marked this pull request as ready for review April 28, 2025 14:46
@cdiielsi cdiielsi requested a review from a team as a code owner April 28, 2025 14:46
JereSalo
JereSalo approved these changes Apr 28, 2025
View reviewed changes
Copy link
Contributor

@JereSalo JereSalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@cdiielsi cdiielsi added this pull request to the merge queue Apr 28, 2025
Merged via the queue into main with commit b421c5f Apr 28, 2025
20 checks passed
@cdiielsi cdiielsi deleted the revm_test_state branch April 28, 2025 21:46
@cdiielsi cdiielsi restored the revm_test_state branch May 12, 2025 20:01
@cdiielsi cdiielsi deleted the revm_test_state branch May 12, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpaulucci mpaulucci mpaulucci approved these changes

@JereSalo JereSalo JereSalo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cdiielsi @mpaulucci @JereSalo